| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAHp75VftSORts5cbDxvfyHgqhxmb7K74BfPd=mST+75C+Ch9dQ@mail.gmail.com>
Date: Thu, 25 Nov 2021 12:06:27 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Lh Kuo 郭力豪 <lh.Kuo@...plus.com>
Cc: Mark Brown <broonie@...nel.org>, "LH.Kuo" <lhjeff911@...il.com>,
Philipp Zabel <p.zabel@...gutronix.de>,
Rob Herring <robh+dt@...nel.org>,
linux-spi <linux-spi@...r.kernel.org>,
devicetree <devicetree@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
"dvorkin@...bo.com" <dvorkin@...bo.com>,
"qinjian@...lus1.com" <qinjian@...lus1.com>,
Wells Lu 呂芳騰 <wells.lu@...plus.com>
Subject: Re: [PATCH v3 1/2] SPI: Add SPI driver for Sunplus SP7021
On Thu, Nov 25, 2021 at 11:47 AM Lh Kuo 郭力豪 <lh.Kuo@...plus.com> wrote:
> I have already modified most of the driver. And the probe function is as follows. Is it okay?
Can be done a bit better, see below (seems you missed few of the comments)
> static int sp7021_spi_controller_probe(struct platform_device *pdev)
> {
> int ret;
> int mode;
> struct spi_controller *ctlr;
> struct sp7021_spi_ctlr *pspim;
> struct device *dev = &pdev->dev;
Other way around, or i.o.w. "reversed tree".
> mode = SP7021_MASTER_MODE;
> pdev->id = of_alias_get_id(pdev->dev.of_node, "sp_spi");
>
> if (of_property_read_bool(pdev->dev.of_node, "spi-slave"))
> mode = SP7021_SLAVE_MODE;
pdev->id = of_alias_get_id(pdev->dev.of_node, "sp_spi");
mode = SP7021_MASTER_MODE;
if (of_property_read_bool(pdev->dev.of_node, "spi-slave"))
mode = SP7021_SLAVE_MODE;
> if (mode == SP7021_SLAVE_MODE)
> ctlr = devm_spi_alloc_slave(dev, sizeof(*pspim));
> else
> ctlr = devm_spi_alloc_master(dev, sizeof(*pspim));
> if (!ctlr)
> return -ENOMEM;
>
> ctlr->dev.of_node = pdev->dev.of_node;
> ctlr->bus_num = pdev->id;
> ctlr->mode_bits = SPI_CPOL | SPI_CPHA | SPI_CS_HIGH | SPI_LSB_FIRST;
> ctlr->auto_runtime_pm = true;
> ctlr->prepare_message = sp7021_spi_controller_prepare_message;
> if (mode == SP7021_SLAVE_MODE) {
> ctlr->transfer_one = sp7021_spi_sla_transfer_one;
> ctlr->slave_abort = sp7021_spi_sla_abort;
> ctlr->flags = SPI_CONTROLLER_HALF_DUPLEX;
> } else {
> ctlr->bits_per_word_mask = SPI_BPW_MASK(8);
> ctlr->min_speed_hz = 40000;
> ctlr->max_speed_hz = 25000000;
> ctlr->use_gpio_descriptors = true;
> ctlr->flags = SPI_CONTROLLER_MUST_RX | SPI_CONTROLLER_MUST_TX;
> ctlr->transfer_one = sp7021_spi_mas_transfer_one;
> }
> platform_set_drvdata(pdev, ctlr);
> pspim = spi_controller_get_devdata(ctlr);
> pspim->ctlr = ctlr;
> pspim->dev = dev;
> spin_lock_init(&pspim->lock);
> mutex_init(&pspim->buf_lock);
> init_completion(&pspim->isr_done);
> init_completion(&pspim->sla_isr);
> pspim->mas_base = devm_platform_ioremap_resource_byname(pdev, "spi_master");
> pspim->sla_base = devm_platform_ioremap_resource_byname(pdev, "spi_slave");
>
> pspim->mas_irq = platform_get_irq_byname(pdev, "mas_risc_intr");
> if (pspim->mas_irq < 0) {
> dev_err(dev, "failed to get mas intr\n");
Dup. No need to repeat what's done by platform core.
> return pspim->mas_irq;
> }
>
> pspim->sla_irq = platform_get_irq_byname(pdev, "slave_risc_intr");
> if (pspim->sla_irq < 0) {
> dev_err(dev, "failed to get sla intr\n");
Dup.
> return pspim->sla_irq;
> }
>
> ret = devm_request_irq(dev, pspim->mas_irq, sp7021_spi_mas_irq
> , IRQF_TRIGGER_RISING, pdev->name, pspim);
Ugly indentation.
> if (ret) {
> dev_err(dev, "mas intr devm_request_irq fail\n");
> return ret;
> }
>
> ret = devm_request_irq(dev, pspim->sla_irq, sp7021_spi_sla_irq
> , IRQF_TRIGGER_RISING, pdev->name, pspim);
Ditto.
> if (ret) {
> dev_err(dev, "slave intr devm_request_irq fail\n");
> return ret;
> }
>
> pspim->spi_clk = devm_clk_get(dev, NULL);
> if (IS_ERR(pspim->spi_clk)) {
> return dev_err_probe(dev, PTR_ERR(pspim->spi_clk), "clk get fail\n");
> }
Does checkpatch compains on this?
Hint: {} around a single statement shouldn't be added.
> pspim->rstc = devm_reset_control_get_exclusive(dev, NULL);
> if (IS_ERR(pspim->rstc)) {
> return dev_err_probe(dev, PTR_ERR(pspim->rstc), "rst get fail\n");
Ditto.
> }
>
> ret = clk_prepare_enable(pspim->spi_clk);
> if (ret)
> return dev_err_probe(dev, ret,
> "failed to enable clk\n");
One line
> ret = reset_control_deassert(pspim->rstc);
> if (ret) {
> dev_err_probe(dev, ret,
> "failed to deassert reset\n");
One line.
> goto free_reset_assert;
>
Really, pay attention to a stray blank line here and there.
> }
>
> pm_runtime_enable(dev);
>
> ret = devm_spi_register_controller(dev, ctlr);
You can't mix non-devm with devm APIs. Either all non-devm, or devm
followed by non-devm.
> if (ret) {
> dev_err(dev, "spi_register_master fail\n");
> goto err_disable_pm_runtime;
> }
>
> return ret;
>
> err_disable_pm_runtime:
> pm_runtime_disable(dev);
> free_reset_assert:
> reset_control_assert(pspim->rstc);
> clk_disable_unprepare(pspim->spi_clk);
>
> return ret;
> }
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists