linux-kernel - Re: [PATCH] media: i2c: dw9714: add optional regulator support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YZ93/dhTH3pUUHm2@sirena.org.uk>
Date:   Thu, 25 Nov 2021 11:48:13 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Martin Kepplinger <martin.kepplinger@...i.sm>
Cc:     sakari.ailus@...ux.intel.com, mchehab@...nel.org,
        lgirdwood@...il.com, linux-media@...r.kernel.org, kernel@...i.sm,
        linux-kernel@...r.kernel.org, Angus Ainslie <angus@...ea.ca>
Subject: Re: [PATCH] media: i2c: dw9714: add optional regulator support

On Thu, Nov 25, 2021 at 09:09:22AM +0100, Martin Kepplinger wrote:

> +	dw9714_dev->vcc = devm_regulator_get_optional(&client->dev, "vcc");
> +	if (IS_ERR(dw9714_dev->vcc)) {
> +		if (PTR_ERR(dw9714_dev->vcc) != -ENODEV)

This looks like an abuse of regulator_get_optiona(), unless the supply
might be physically absent in a system it should be using a normal
regulator_get().

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)