| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20211125144053.774-5-olivier.moysan@foss.st.com>
Date: Thu, 25 Nov 2021 15:40:53 +0100
From: Olivier Moysan <olivier.moysan@...s.st.com>
To: Alexandre Torgue <alexandre.torgue@...s.st.com>,
Liam Girdwood <lgirdwood@...il.com>,
Mark Brown <broonie@...nel.org>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Olivier Moysan <olivier.moysan@...com>,
"Rob Herring" <robh+dt@...nel.org>, <arnaud.pouliquen@...s.st.com>,
<amelie.delaunay@...s.st.com>, <alain.volmat@...s.st.com>
CC: <alsa-devel@...a-project.org>, <devicetree@...r.kernel.org>,
<linux-arm-kernel@...ts.infradead.org>,
<linux-kernel@...r.kernel.org>,
<linux-stm32@...md-mailman.stormreply.com>,
<fabrice.gasnier@...s.st.com>,
Olivier Moysan <olivier.moysan@...s.st.com>
Subject: [PATCH v2 4/4] ARM: dts: stm32: merge spi and i2s nodes
When a SPI instance offers I2S feature, two nodes are defined
in SoC device tree to support both SPI and I2S.
Merge SPI node and I2S nodes into a single node, to avoid
hardware description duplication and compilation warnings.
spi2sx label is used to identify the SPI instances which
are supporting I2S feature.
Rename nodes, to match new labels of SPI/I2S nodes in the
SoC device tree on following boards:
- STMP32MP15xx-DKx
- STMP32MP157C-EV1
- STMP32MP15xx-dhcor-avenger96
- STMP32MP15xx-dhcom-drc02
In DT check utility, the spi2s2 node is identified as an spi node.
The check_spi_bus_reg() function issues a warning "missing or empty
reg property" if reg property is not defined in child nodes.
Add reg property to STM32 I2S port node on STM32MP15XX-DK board
to match this requirement and add related unit-address in node name.
Signed-off-by: Olivier Moysan <olivier.moysan@...s.st.com>
---
arch/arm/boot/dts/stm32mp151.dtsi | 39 ++-----------------
arch/arm/boot/dts/stm32mp157c-ev1.dts | 2 +-
.../arm/boot/dts/stm32mp15xx-dhcom-drc02.dtsi | 2 +-
.../boot/dts/stm32mp15xx-dhcor-avenger96.dtsi | 2 +-
arch/arm/boot/dts/stm32mp15xx-dkx.dtsi | 7 +++-
5 files changed, 11 insertions(+), 41 deletions(-)
diff --git a/arch/arm/boot/dts/stm32mp151.dtsi b/arch/arm/boot/dts/stm32mp151.dtsi
index f693a7d24247..61226821ff8c 100644
--- a/arch/arm/boot/dts/stm32mp151.dtsi
+++ b/arch/arm/boot/dts/stm32mp151.dtsi
@@ -386,7 +386,7 @@
};
};
- spi2: spi@...0b000 {
+ spi2s2: spi@...0b000 {
#address-cells = <1>;
#size-cells = <0>;
compatible = "st,stm32h7-spi";
@@ -400,18 +400,7 @@
status = "disabled";
};
- i2s2: audio-controller@...0b000 {
- compatible = "st,stm32h7-i2s";
- #sound-dai-cells = <0>;
- reg = <0x4000b000 0x400>;
- interrupts = <GIC_SPI 36 IRQ_TYPE_LEVEL_HIGH>;
- dmas = <&dmamux1 39 0x400 0x01>,
- <&dmamux1 40 0x400 0x01>;
- dma-names = "rx", "tx";
- status = "disabled";
- };
-
- spi3: spi@...0c000 {
+ spi2s3: spi@...0c000 {
#address-cells = <1>;
#size-cells = <0>;
compatible = "st,stm32h7-spi";
@@ -425,17 +414,6 @@
status = "disabled";
};
- i2s3: audio-controller@...0c000 {
- compatible = "st,stm32h7-i2s";
- #sound-dai-cells = <0>;
- reg = <0x4000c000 0x400>;
- interrupts = <GIC_SPI 51 IRQ_TYPE_LEVEL_HIGH>;
- dmas = <&dmamux1 61 0x400 0x01>,
- <&dmamux1 62 0x400 0x01>;
- dma-names = "rx", "tx";
- status = "disabled";
- };
-
spdifrx: audio-controller@...0d000 {
compatible = "st,stm32h7-spdifrx";
#sound-dai-cells = <0>;
@@ -681,7 +659,7 @@
status = "disabled";
};
- spi1: spi@...04000 {
+ spi2s1: spi@...04000 {
#address-cells = <1>;
#size-cells = <0>;
compatible = "st,stm32h7-spi";
@@ -695,17 +673,6 @@
status = "disabled";
};
- i2s1: audio-controller@...04000 {
- compatible = "st,stm32h7-i2s";
- #sound-dai-cells = <0>;
- reg = <0x44004000 0x400>;
- interrupts = <GIC_SPI 35 IRQ_TYPE_LEVEL_HIGH>;
- dmas = <&dmamux1 37 0x400 0x01>,
- <&dmamux1 38 0x400 0x01>;
- dma-names = "rx", "tx";
- status = "disabled";
- };
-
spi4: spi@...05000 {
#address-cells = <1>;
#size-cells = <0>;
diff --git a/arch/arm/boot/dts/stm32mp157c-ev1.dts b/arch/arm/boot/dts/stm32mp157c-ev1.dts
index 5c5b1ddf7bfd..c836b4a1dbe2 100644
--- a/arch/arm/boot/dts/stm32mp157c-ev1.dts
+++ b/arch/arm/boot/dts/stm32mp157c-ev1.dts
@@ -293,7 +293,7 @@
status = "disabled";
};
-&spi1 {
+&spi2s1 {
pinctrl-names = "default";
pinctrl-0 = <&spi1_pins_a>;
status = "disabled";
diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcom-drc02.dtsi b/arch/arm/boot/dts/stm32mp15xx-dhcom-drc02.dtsi
index 4b10b013ffd5..29f18382d962 100644
--- a/arch/arm/boot/dts/stm32mp15xx-dhcom-drc02.dtsi
+++ b/arch/arm/boot/dts/stm32mp15xx-dhcom-drc02.dtsi
@@ -114,7 +114,7 @@
disable-wp;
};
-&spi1 {
+&spi2s1 {
pinctrl-names = "default";
pinctrl-0 = <&spi1_pins_a>;
cs-gpios = <&gpioz 3 0>;
diff --git a/arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi b/arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi
index 6885948f3024..0dce9b118318 100644
--- a/arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi
+++ b/arch/arm/boot/dts/stm32mp15xx-dhcor-avenger96.dtsi
@@ -362,7 +362,7 @@
};
};
-&spi2 {
+&spi2s2 {
pinctrl-names = "default";
pinctrl-0 = <&spi2_pins_a>;
cs-gpios = <&gpioi 0 0>;
diff --git a/arch/arm/boot/dts/stm32mp15xx-dkx.dtsi b/arch/arm/boot/dts/stm32mp15xx-dkx.dtsi
index 48beed0f1f30..4c362af95736 100644
--- a/arch/arm/boot/dts/stm32mp15xx-dkx.dtsi
+++ b/arch/arm/boot/dts/stm32mp15xx-dkx.dtsi
@@ -427,7 +427,9 @@
status = "disabled";
};
-&i2s2 {
+&spi2s2 {
+ compatible = "st,stm32h7-i2s";
+ #sound-dai-cells = <0>;
clocks = <&rcc SPI2>, <&rcc SPI2_K>, <&rcc PLL3_Q>, <&rcc PLL3_R>;
clock-names = "pclk", "i2sclk", "x8k", "x11k";
pinctrl-names = "default", "sleep";
@@ -435,7 +437,8 @@
pinctrl-1 = <&i2s2_sleep_pins_a>;
status = "okay";
- i2s2_port: port {
+ i2s2_port: port@0 {
+ reg = <0>;
i2s2_endpoint: endpoint {
remote-endpoint = <&sii9022_tx_endpoint>;
format = "i2s";
--
2.17.1
Powered by blists - more mailing lists