linux-kernel - Re: [PATCH v3 0/6] staging: media: wave5: add wave5 codec driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <c8a766f2-137b-5c17-74b0-6acf6e0338d2@xs4all.nl>
Date:   Thu, 25 Nov 2021 16:08:06 +0100
From:   Hans Verkuil <hverkuil@...all.nl>
To:     Dafna Hirschfeld <dafna.hirschfeld@...labora.com>,
        linux-media@...r.kernel.org
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "open list:STAGING SUBSYSTEM" <linux-staging@...ts.linux.dev>,
        open list <linux-kernel@...r.kernel.org>,
        laurent.pinchart@...asonboard.com, kernel@...labora.com,
        dafna3@...il.com, bob.beckett@...labora.com,
        kiril.bicevski@...labora.com,
        Nas Chung <nas.chung@...psnmedia.com>,
        lafley.kim@...psnmedia.com, scott.woo@...psnmedia.com,
        olivier.crete@...labora.com, dan.carpenter@...cle.com,
        rdunlap@...radead.org
Subject: Re: [PATCH v3 0/6] staging: media: wave5: add wave5 codec driver

Hi Dafna,

Just a high-level comment below:

On 10/11/2021 13:09, Dafna Hirschfeld wrote:
> The wave5 codec is a stateful encoder/decoder.
> It is found on the JH7100 SoC.
> 
> The driver currently supports V4L2_PIX_FMT_HEVC, V4L2_PIX_FMT_H264.
> 
> This driver has so far been tested on pre-silicon FPGA and on the beta BeagleV
> board which uses the StarFive JH7100 beta SoC.
> 
> Testing on FPGA shows it working fine, though the FPGA uses polled interrupts
> and copied buffers between the host and it's on board RAM.
> 
> Testing on BeagleV shows buffer corruption that is currently attributed to a
> known silicon issue in the SoC that makes the cache coherent interconnect not
> so coherent.
> This can likely be solved when the riscv non-coherent dma support lands and
> provide optional v4l2 non-contiguous allocator, though it remains to be seen
> whether support non-coherent use cases will be useful in real world hw.
> 
> Until we can test and resolve any issues on final silicon (due 2H 2021)
> this driver should remain in staging.
> 
> We currently tested only the decoder.
> Testing the encoder is currently impossible because of the BeagleV buffer problems,
> That will need to be tested once we have fixed beaglev buffer problems.
> 
> v4l2-compliance all pass for v2 as well.
> 
> changes since v1:
> 
> Main fixes includes:
> * change the yaml and dirver code to support up to 4 clks (instead of one)
> * fix Kconfig format
> * remove unneeded cast,
> * change var types
> * change var names, func names
> * checkpatch fixes
> 
> 
> Dafna Hirschfeld (4):
>   staging: media: wave5: Add vpuapi layer
>   staging: media: wave5: Add the vdi layer
>   staging: media: wave5: Add the v4l2 layer
>   staging: media: wave5: Add TODO file
> 
> Robert Beckett (2):
>   dt-bindings: media: staging: wave5: add yaml devicetree bindings
>   media: wave5: Add wave5 driver to maintainers file
> 
>  .../bindings/staging/media/cnm,wave.yaml      |   73 +
>  MAINTAINERS                                   |    9 +
>  drivers/staging/media/Kconfig                 |    2 +
>  drivers/staging/media/Makefile                |    1 +
>  drivers/staging/media/wave5/Kconfig           |   12 +
>  drivers/staging/media/wave5/Makefile          |   10 +
>  drivers/staging/media/wave5/TODO              |   59 +
>  drivers/staging/media/wave5/vdi.c             |  260 ++
>  drivers/staging/media/wave5/vdi.h             |   76 +
>  drivers/staging/media/wave5/vpu.c             |  367 ++
>  drivers/staging/media/wave5/vpu.h             |   64 +
>  drivers/staging/media/wave5/vpu_dec.c         | 1397 +++++++
>  drivers/staging/media/wave5/vpu_enc.c         | 1585 ++++++++
>  drivers/staging/media/wave5/vpuapi.c          | 1066 +++++
>  drivers/staging/media/wave5/vpuapi.h          | 1140 ++++++
>  drivers/staging/media/wave5/vpuconfig.h       |   85 +
>  drivers/staging/media/wave5/vpuerror.h        |  455 +++
>  drivers/staging/media/wave5/wave5-hw.c        | 3476 +++++++++++++++++
>  drivers/staging/media/wave5/wave5.h           |   81 +
>  drivers/staging/media/wave5/wave5_regdefine.h |  638 +++

Please prefix the source/header filenames with 'wave5_' (or 'wave5-',
as long as it is consistent).

See e.g. drivers/staging/media/hantro/ or really any media driver.
If you just see the filename then you can at least tell for which driver
it is. Just 'vpu.c' is not descriptive enough.

For the next version I would also like to see the v4l2-compliance output.

Regards,

	Hans

>  20 files changed, 10856 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/staging/media/cnm,wave.yaml
>  create mode 100644 drivers/staging/media/wave5/Kconfig
>  create mode 100644 drivers/staging/media/wave5/Makefile
>  create mode 100644 drivers/staging/media/wave5/TODO
>  create mode 100644 drivers/staging/media/wave5/vdi.c
>  create mode 100644 drivers/staging/media/wave5/vdi.h
>  create mode 100644 drivers/staging/media/wave5/vpu.c
>  create mode 100644 drivers/staging/media/wave5/vpu.h
>  create mode 100644 drivers/staging/media/wave5/vpu_dec.c
>  create mode 100644 drivers/staging/media/wave5/vpu_enc.c
>  create mode 100644 drivers/staging/media/wave5/vpuapi.c
>  create mode 100644 drivers/staging/media/wave5/vpuapi.h
>  create mode 100644 drivers/staging/media/wave5/vpuconfig.h
>  create mode 100644 drivers/staging/media/wave5/vpuerror.h
>  create mode 100644 drivers/staging/media/wave5/wave5-hw.c
>  create mode 100644 drivers/staging/media/wave5/wave5.h
>  create mode 100644 drivers/staging/media/wave5/wave5_regdefine.h
>