linux-kernel - Re: [PATCH 4.9 000/206] 4.9.291-rc2 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 25 Nov 2021 16:56:36 +0100
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Guenter Roeck <linux@...ck-us.net>, Nadav Amit <namit@...are.com>
Cc:     linux-kernel@...r.kernel.org, torvalds@...ux-foundation.org,
        akpm@...ux-foundation.org, shuah@...nel.org, patches@...nelci.org,
        lkft-triage@...ts.linaro.org, pavel@...x.de, jonathanh@...dia.com,
        f.fainelli@...il.com, stable@...r.kernel.org
Subject: Re: [PATCH 4.9 000/206] 4.9.291-rc2 review

On Thu, Nov 25, 2021 at 07:45:22AM -0800, Guenter Roeck wrote:
> On 11/25/21 4:57 AM, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 4.9.291 release.
> > There are 206 patches in this series, all will be posted as a response
> > to this one.  If anyone has any issues with these being applied, please
> > let me know.
> > 
> > Responses should be made by Sat, 27 Nov 2021 12:56:08 +0000.
> > Anything received after that time might be too late.
> > 
> 
> In file included from arch/sh/mm/init.c:25:
> arch/sh/include/asm/tlb.h:118:15: error: return type defaults to 'int' [-Werror=return-type]
>   118 | static inline tlb_flush_pmd_range(struct mmu_gather *tlb, unsigned long address,
> 
> The problem affects v4.9.y, v4.14.y, and v4.19.y.
> 
> Commit aca917cb287ba99c5 ("hugetlbfs: flush TLBs correctly after huge_pmd_unshare")
> doesn't really match the upstream commit and obviously was not even build tested
> on sh (and I would suspect it was not tested on other architectures either).
> It seems to me that it may do more harm than good.

Ok, at this point in time, I think this needs more work, especially over
a holliday weekend for parts of the world.

I'll go drop this, and the other hugetlb patch from 4.4, 4.9, 4.14, and
4.19 queues and wait for a new version from Nadav.

thanks,

greg k-h