linux-kernel - Re: [PATCH] RDMA: fix use-after-free in rxe_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211125172555.GA490586@nvidia.com>
Date:   Thu, 25 Nov 2021 13:25:55 -0400
From:   Jason Gunthorpe <jgg@...dia.com>
To:     Pavel Skripkin <paskripkin@...il.com>
Cc:     zyjzyj2000@...il.com, dledford@...hat.com, leon@...nel.org,
        linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
        syzbot+aab53008a5adf26abe91@...kaller.appspotmail.com
Subject: Re: [PATCH] RDMA: fix use-after-free in rxe_queue_cleanup

On Sun, Nov 21, 2021 at 11:22:39PM +0300, Pavel Skripkin wrote:
> On error handling path in rxe_qp_from_init() qp->sq.queue is freed and
> then rxe_create_qp() will drop last reference to this object. qp clean
> up function will try to free this queue one time and it causes UAF bug.
> 
> Fix it by zeroing queue pointer after freeing queue in
> rxe_qp_from_init().
> 
> Fixes: 514aee660df4 ("RDMA: Globally allocate and release QP memory")
> Reported-by: syzbot+aab53008a5adf26abe91@...kaller.appspotmail.com
> Signed-off-by: Pavel Skripkin <paskripkin@...il.com>
> Reviewed-by: Zhu Yanjun <zyjzyj2000@...il.com>
> ---
>  drivers/infiniband/sw/rxe/rxe_qp.c | 1 +
>  1 file changed, 1 insertion(+)

Applied to for-next, thanks

Jason