linux-kernel - Re: [PATCH for-rc v2] RDMA/cma: Remove open coding of overflow checking for private_data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211125173716.GA504001@nvidia.com>
Date:   Thu, 25 Nov 2021 13:37:16 -0400
From:   Jason Gunthorpe <jgg@...dia.com>
To:     Håkon Bugge <haakon.bugge@...cle.com>
Cc:     Leon Romanovsky <leon@...nel.org>, linux-rdma@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH for-rc v2] RDMA/cma: Remove open coding of overflow
 checking for private_data_len

On Tue, Nov 23, 2021 at 11:06:18AM +0100, Håkon Bugge wrote:
> The existing tests are a little hard to comprehend. Use
> check_add_overflow() instead.
> 
> Fixes: 04ded1672402 ("RDMA/cma: Verify private data length")
> Signed-off-by: Håkon Bugge <haakon.bugge@...cle.com>
> Reviewed-by: Leon Romanovsky <leonro@...dia.com>
> ---
> 
> v1 -> v2:
> 
>    * Also fixed same issue in cma_resolve_ib_udp() as pointed out
>      by Leon
> ---
>  drivers/infiniband/core/cma.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)

Applied to for-next, thanks

Jason