linux-kernel - Re: [PATCH 4/4] staging: r8188eu: loadparam needs no net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 25 Nov 2021 18:48:59 +0100
From:   Michael Straube <straube.linux@...il.com>
To:     Martin Kaiser <martin@...ser.cx>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Larry Finger <Larry.Finger@...inger.net>,
        Phillip Potter <phil@...lpotter.co.uk>,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] staging: r8188eu: loadparam needs no net_device

On 11/25/21 17:47, Martin Kaiser wrote:
> Remove the second parameter of the loadparam function. This parameter
> is not used.
> 
> Signed-off-by: Martin Kaiser <martin@...ser.cx>
> ---
>   drivers/staging/r8188eu/os_dep/os_intfs.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/os_dep/os_intfs.c b/drivers/staging/r8188eu/os_dep/os_intfs.c
> index 397981bc9a62..02700834c587 100644
> --- a/drivers/staging/r8188eu/os_dep/os_intfs.c
> +++ b/drivers/staging/r8188eu/os_dep/os_intfs.c
> @@ -153,7 +153,7 @@ MODULE_PARM_DESC(rtw_notch_filter, "0:Disable, 1:Enable, 2:Enable only for P2P")
>   module_param_named(debug, rtw_debug, int, 0444);
>   MODULE_PARM_DESC(debug, "Set debug level (1-9) (default 1)");
>   
> -static uint loadparam(struct adapter *padapter,  struct  net_device *pnetdev)
> +static uint loadparam(struct adapter *padapter)
>   {
>   	struct registry_priv  *registry_par = &padapter->registrypriv;
>   
> @@ -371,7 +371,7 @@ struct net_device *rtw_init_netdev(struct adapter *old_padapter)
>   	pnetdev->wireless_handlers = (struct iw_handler_def *)&rtw_handlers_def;
>   
>   	/* step 2. */
> -	loadparam(padapter, pnetdev);
> +	loadparam(padapter);
>   
>   	return pnetdev;
>   }
> 

Reviewed-by: Michael Straube <straube.linux@...il.com>