linux-kernel - Re: [PATCH v4 12/12] gpio: Add support for Airoha EN7523 GPIO controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VcofiOE4LKqTjnXco26Yd5a4VWYkQE3gNU8Z3zr70woVA@mail.gmail.com>
Date:   Fri, 26 Nov 2021 18:57:47 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Bartosz Golaszewski <brgl@...ev.pl>
Cc:     Felix Fietkau <nbd@....name>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        Rob Herring <robh+dt@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        John Crispin <john@...ozen.org>,
        devicetree <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH v4 12/12] gpio: Add support for Airoha EN7523 GPIO controller

On Fri, Nov 26, 2021 at 6:40 PM Bartosz Golaszewski <brgl@...ev.pl> wrote:
> On Thu, Nov 25, 2021 at 12:24 PM Felix Fietkau <nbd@....name> wrote:
> >
> > From: John Crispin <john@...ozen.org>
> >
> > Airoha's GPIO controller on their ARM EN7523 SoCs consists of two banks of 32
> > GPIOs. Each instance in DT is for an single bank.

a single

...

> > +       err = bgpio_init(&ctrl->gc, dev, 4, ctrl->data, NULL,
> > +                        NULL, NULL, NULL, 0);
> > +       if (err) {
> > +               dev_err(dev, "unable to init generic GPIO");
> > +               return err;
> > +       }

Since it will be a new version you may have a chance to replace this with

  return dev_err_probe(dev, err, ...);

-- 
With Best Regards,
Andy Shevchenko