linux-kernel - kernel/trace/trace_osnoise.c:131:1: sparse: sparse: symbol '__pcpu_scope_per_cpu_timerlat_var' was not declared. Should it be static?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sat, 27 Nov 2021 02:01:44 +0800
From:   kernel test robot <lkp@...el.com>
To:     Daniel Bristot de Oliveira <bristot@...hat.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        "Steven Rostedt (VMware)" <rostedt@...dmis.org>
Subject: kernel/trace/trace_osnoise.c:131:1: sparse: sparse: symbol
 '__pcpu_scope_per_cpu_timerlat_var' was not declared. Should it be static?

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   a4849f6000e29235a2707f22e39da6b897bb9543
commit: 498627b4ac85780b9962ed9b5c5abbefd884ef8e trace/osnoise: Fix return value on osnoise_init_hotplug_support
date:   5 months ago
config: i386-randconfig-s002-20211118 (https://download.01.org/0day-ci/archive/20211127/202111270153.j3tgBvDJ-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=498627b4ac85780b9962ed9b5c5abbefd884ef8e
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 498627b4ac85780b9962ed9b5c5abbefd884ef8e
        # save the config file to linux build tree
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=i386 SHELL=/bin/bash kernel/trace/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>


sparse warnings: (new ones prefixed by >>)
   kernel/trace/trace_osnoise.c:108:1: sparse: sparse: symbol '__pcpu_scope_per_cpu_osnoise_var' was not declared. Should it be static?
>> kernel/trace/trace_osnoise.c:131:1: sparse: sparse: symbol '__pcpu_scope_per_cpu_timerlat_var' was not declared. Should it be static?
   kernel/trace/trace_osnoise.c:223:14: sparse: sparse: symbol 'interface_lock' was not declared. Should it be static?
   kernel/trace/trace_osnoise.c:1766:5: sparse: sparse: symbol 'timerlat_min_period' was not declared. Should it be static?
   kernel/trace/trace_osnoise.c:1767:5: sparse: sparse: symbol 'timerlat_max_period' was not declared. Should it be static?

vim +/__pcpu_scope_per_cpu_timerlat_var +131 kernel/trace/trace_osnoise.c

bce29ac9ce0bb0b Daniel Bristot de Oliveira 2021-06-22  112   */
bce29ac9ce0bb0b Daniel Bristot de Oliveira 2021-06-22  113  static inline struct osnoise_variables *this_cpu_osn_var(void)
bce29ac9ce0bb0b Daniel Bristot de Oliveira 2021-06-22  114  {
bce29ac9ce0bb0b Daniel Bristot de Oliveira 2021-06-22  115  	return this_cpu_ptr(&per_cpu_osnoise_var);
bce29ac9ce0bb0b Daniel Bristot de Oliveira 2021-06-22  116  }
bce29ac9ce0bb0b Daniel Bristot de Oliveira 2021-06-22  117  
a955d7eac1779b4 Daniel Bristot de Oliveira 2021-06-22  118  #ifdef CONFIG_TIMERLAT_TRACER
bce29ac9ce0bb0b Daniel Bristot de Oliveira 2021-06-22  119  /*
a955d7eac1779b4 Daniel Bristot de Oliveira 2021-06-22  120   * Runtime information for the timer mode.
bce29ac9ce0bb0b Daniel Bristot de Oliveira 2021-06-22  121   */
a955d7eac1779b4 Daniel Bristot de Oliveira 2021-06-22  122  struct timerlat_variables {
a955d7eac1779b4 Daniel Bristot de Oliveira 2021-06-22  123  	struct task_struct	*kthread;
a955d7eac1779b4 Daniel Bristot de Oliveira 2021-06-22  124  	struct hrtimer		timer;
a955d7eac1779b4 Daniel Bristot de Oliveira 2021-06-22  125  	u64			rel_period;
a955d7eac1779b4 Daniel Bristot de Oliveira 2021-06-22  126  	u64			abs_period;
a955d7eac1779b4 Daniel Bristot de Oliveira 2021-06-22  127  	bool			tracing_thread;
a955d7eac1779b4 Daniel Bristot de Oliveira 2021-06-22  128  	u64			count;
a955d7eac1779b4 Daniel Bristot de Oliveira 2021-06-22  129  };
a955d7eac1779b4 Daniel Bristot de Oliveira 2021-06-22  130  
a955d7eac1779b4 Daniel Bristot de Oliveira 2021-06-22 @131  DEFINE_PER_CPU(struct timerlat_variables, per_cpu_timerlat_var);
a955d7eac1779b4 Daniel Bristot de Oliveira 2021-06-22  132  
a955d7eac1779b4 Daniel Bristot de Oliveira 2021-06-22  133  /*
a955d7eac1779b4 Daniel Bristot de Oliveira 2021-06-22  134   * this_cpu_tmr_var - Return the per-cpu timerlat_variables on its relative CPU
a955d7eac1779b4 Daniel Bristot de Oliveira 2021-06-22  135   */
a955d7eac1779b4 Daniel Bristot de Oliveira 2021-06-22  136  static inline struct timerlat_variables *this_cpu_tmr_var(void)
bce29ac9ce0bb0b Daniel Bristot de Oliveira 2021-06-22  137  {
a955d7eac1779b4 Daniel Bristot de Oliveira 2021-06-22  138  	return this_cpu_ptr(&per_cpu_timerlat_var);
a955d7eac1779b4 Daniel Bristot de Oliveira 2021-06-22  139  }
a955d7eac1779b4 Daniel Bristot de Oliveira 2021-06-22  140  
a955d7eac1779b4 Daniel Bristot de Oliveira 2021-06-22  141  /*
a955d7eac1779b4 Daniel Bristot de Oliveira 2021-06-22  142   * tlat_var_reset - Reset the values of the given timerlat_variables
a955d7eac1779b4 Daniel Bristot de Oliveira 2021-06-22  143   */
a955d7eac1779b4 Daniel Bristot de Oliveira 2021-06-22  144  static inline void tlat_var_reset(void)

:::::: The code at line 131 was first introduced by commit
:::::: a955d7eac1779b437ceb24fc352026a2cbcec140 trace: Add timerlat tracer

:::::: TO: Daniel Bristot de Oliveira <bristot@...hat.com>
:::::: CC: Steven Rostedt (VMware) <rostedt@...dmis.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org