linux-kernel - Re: [PATCH net] ethtool: ioctl: fix potential NULL deref in ethtool_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <163795500959.14661.4830039441198215968.git-patchwork-notify@kernel.org>
Date:   Fri, 26 Nov 2021 19:30:09 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Julian Wiedmann <jwi@...ux.ibm.com>
Cc:     davem@...emloft.net, kuba@...nel.org, moyufeng@...wei.com,
        tanhuazhong@...wei.com, andrew@...n.ch, hkallweit1@...il.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] ethtool: ioctl: fix potential NULL deref in
 ethtool_set_coalesce()

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@...nel.org>:

On Fri, 26 Nov 2021 18:55:43 +0100 you wrote:
> ethtool_set_coalesce() now uses both the .get_coalesce() and
> .set_coalesce() callbacks. But the check for their availability is
> buggy, so changing the coalesce settings on a device where the driver
> provides only _one_ of the callbacks results in a NULL pointer
> dereference instead of an -EOPNOTSUPP.
> 
> Fix the condition so that the availability of both callbacks is
> ensured. This also matches the netlink code.
> 
> [...]

Here is the summary with links:
  - [net] ethtool: ioctl: fix potential NULL deref in ethtool_set_coalesce()
    https://git.kernel.org/netdev/net/c/0276af2176c7

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html