linux-kernel - Re: [PATCH] net: usb: lan78xx: lan78xx_phy_init(): use PHY_POLL instead of "0" if no IRQ is available

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211126113440.5463ff74@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Fri, 26 Nov 2021 11:34:53 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Andrew Lunn <andrew@...n.ch>,
        Sven Schuchmann <schuchmann@...leissheimer.de>
Cc:     Woojung Huh <woojung.huh@...rochip.com>,
        UNGLinuxDriver@...rochip.com,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: usb: lan78xx: lan78xx_phy_init(): use PHY_POLL
 instead of "0" if no IRQ is available

On Fri, 26 Nov 2021 16:57:50 +0100 Andrew Lunn wrote:
> On Fri, Nov 26, 2021 at 04:20:40PM +0100, Sven Schuchmann wrote:
> > On most systems request for IRQ 0 will fail, phylib will print an error message
> > and fall back to polling. To fix this set the phydev->irq to PHY_POLL if no IRQ
> > is available.
> > 
> > Signed-off-by: Sven Schuchmann <schuchmann@...leissheimer.de>  
> 
> Reviewed-by: Andrew Lunn <andrew@...n.ch>

Fixes: cc89c323a30e ("lan78xx: Use irq_domain for phy interrupt from USB Int. EP")

right?