linux-kernel - Re: [PATCH] vdpa: Consider device id larger than 31

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACGkMEtF+kjj_vryxXAo6PqeX3Puk-XxaaQMcu4mhB1WZRXEpw@mail.gmail.com>
Date:   Fri, 26 Nov 2021 10:48:12 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     Parav Pandit <parav@...dia.com>
Cc:     virtualization <virtualization@...ts.linux-foundation.org>,
        mst <mst@...hat.com>, Eric Dumazet <edumazet@...gle.com>,
        kbuild-all@...ts.01.org, kernel test robot <lkp@...el.com>,
        linux-kernel <linux-kernel@...r.kernel.org>, kbuild@...ts.01.org,
        Eli Cohen <elic@...dia.com>,
        Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: [PATCH] vdpa: Consider device id larger than 31

On Fri, Nov 26, 2021 at 2:09 AM Parav Pandit <parav@...dia.com> wrote:
>
> virtio device id value can be more than 31. Hence, use BIT_ULL in
> assignment.
>
> Fixes: 33b347503f01 ("vdpa: Define vdpa mgmt device, ops and a netlink interface")
> Reported-by: kernel test robot <lkp@...el.com>
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Parav Pandit <parav@...dia.com>

Acked-by: Jason Wang <jasowang@...hat.com>

> ---
>  drivers/vdpa/vdpa.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vdpa/vdpa.c b/drivers/vdpa/vdpa.c
> index 7332a74a4b00..e91c71aeeddf 100644
> --- a/drivers/vdpa/vdpa.c
> +++ b/drivers/vdpa/vdpa.c
> @@ -404,7 +404,7 @@ static int vdpa_mgmtdev_fill(const struct vdpa_mgmt_dev *mdev, struct sk_buff *m
>                 goto msg_err;
>
>         while (mdev->id_table[i].device) {
> -               supported_classes |= BIT(mdev->id_table[i].device);
> +               supported_classes |= BIT_ULL(mdev->id_table[i].device);
>                 i++;
>         }
>
> --
> 2.26.2
>