linux-kernel - Re: [PATCH v4] i2c: tegra: Add the ACPI support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 26 Nov 2021 04:02:40 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Akhil R <akhilrajeev@...dia.com>
Cc:     andy.shevchenko@...il.com, christian.koenig@....com,
        dri-devel@...ts.freedesktop.org, jonathanh@...dia.com,
        ldewangan@...dia.com, linaro-mm-sig@...ts.linaro.org,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-media@...r.kernel.org, linux-tegra@...r.kernel.org,
        p.zabel@...gutronix.de, sumit.semwal@...aro.org,
        thierry.reding@...il.com
Subject: Re: [PATCH v4] i2c: tegra: Add the ACPI support

25.11.2021 19:53, Akhil R пишет:
> Add support for the ACPI based device registration so that the driver
> can be also enabled through ACPI table.
> 
> This does not include the ACPI support for Tegra VI and DVC I2C.
> 
> Signed-off-by: Akhil R <akhilrajeev@...dia.com>
> ---
>  drivers/i2c/busses/i2c-tegra.c | 52 ++++++++++++++++++++++++++++++++----------
>  1 file changed, 40 insertions(+), 12 deletions(-)
> 
> v4 changes:
>   * changed has_acpi_companion to ACPI_HANDLE for consistency across 
>     all functions
> v3 - https://lkml.org/lkml/2021/11/25/173
> v2 - https://lkml.org/lkml/2021/11/23/82
> v1 - https://lkml.org/lkml/2021/11/19/393

Andy suggested to make v5 with extra patch that will make use of the
generic i2c_timings, but it should be a separate change.

This patch is good to me. Please provide the full changelog for each
version next time, instead of the links. Thanks!

If you'll make v5, then feel free to add my r-b:

Reviewed-by: Dmitry Osipenko <digetx@...il.com>