linux-kernel - Re: [PATCH v3 2/2] dt-bindings: pinctrl: add bindings for Milbeaut pin controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 26 Nov 2021 02:14:38 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Sugaya Taichi <sugaya.taichi@...ionext.com>
Cc:     Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        orito.takao@...ionext.com,
        Masami Hiramatsu <masami.hiramatsu@...aro.org>,
        Jassi Brar <jaswinder.singh@...aro.org>
Subject: Re: [PATCH v3 2/2] dt-bindings: pinctrl: add bindings for Milbeaut
 pin controller

On Thu, Nov 25, 2021 at 10:58 AM Sugaya Taichi
<sugaya.taichi@...ionext.com> wrote:

> Add Device Tree bindings documentation for pin controller of
> the Milbeaut SoCs.
>
> Signed-off-by: Sugaya Taichi <sugaya.taichi@...ionext.com>

What is weird about this binding is what is not there:
this is just GPIO, where are the pin mux and config
nodes? The driver surely tries to use them.

Please use the existing standard bindings for functions
and groups etc, check the other bindings.

Yours,
Linus Walleij

> ---
>  .../pinctrl/socionext,milbeaut-pinctrl.yaml        | 51 ++++++++++++++++++++++
>  1 file changed, 51 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/pinctrl/socionext,milbeaut-pinctrl.yaml
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/socionext,milbeaut-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/socionext,milbeaut-pinctrl.yaml
> new file mode 100644
> index 0000000..78bc2d4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/socionext,milbeaut-pinctrl.yaml
> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pinctrl/socionext,milbeaut-pinctrl.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Milbeaut SoCs pin controller
> +
> +maintainers:
> +  - Taichi Sugaya <sugaya.taichi@...ionext.com>
> +
> +description: |
> +  Bindings for memory-mapped pin controller of the Milbeaut SoCs.
> +
> +properties:
> +  $nodename:
> +    pattern: "pinctrl"
> +
> +  compatible:
> +    enum:
> +      - socionext,milbeaut-m10v-pinctrl
> +
> +  reg:
> +    maxItems: 1
> +
> +  reg-names:
> +    const: "pinctrl"
> +
> +  gpio-controller: true
> +
> +  "#gpio-cells":
> +    const: 2
> +
> +required:
> +  - compatible
> +  - reg
> +  - reg-names
> +  - gpio-controller
> +  - "#gpio-cells"
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    pinctrl: pinctrl@...22000 {
> +        compatible = "socionext,milbeaut-m10v-pinctrl";
> +        reg = <0x1d022000 0x1000>;
> +        reg-names = "pinctrl";
> +        gpio-controller;
> +        #gpio-cells = <2>;
> +    };
> --
> 2.7.4
>