linux-kernel - Re: [PATCH] [RESEND] fscache: re-match MODULE_PARM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 26 Nov 2021 08:47:59 +0100
From:   Nicolas Schier <nicolas@...sle.eu>
To:     David Howells <dhowells@...hat.com>, linux-cachefs@...hat.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [RESEND] fscache: re-match MODULE_PARM_DESC() calls to
 module parameters

On Mon Sep  6 13:00:41 2021 Nicolas Schier wrote:
> Fix calls of MODULE_PARM_DESC() such that the first argument matches 
> the
> actual module parameter name.  This changes the 'parm' section in the
> output of `modinfo fscache` from:
> 
>     parm: defer_lookup:uint
>     parm: fscache_defer_lookup:Defer cookie lookup to background thread
>     parm: defer_create:uint
>     parm: fscache_defer_create:Defer cookie creation to background thread
>     parm: debug:uint
>     parm: fscache_debug:FS-Cache debugging mask
> 
> into:
> 
>     parm: defer_lookup:Defer cookie lookup to background thread (uint)
>     parm: defer_create:Defer cookie creation to background thread (uint)
>     parm: debug:FS-Cache debugging mask (uint)
> .
> 
> Signed-off-by: Nicolas Schier <nicolas@...sle.eu>
> ---
>  fs/fscache/main.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> --
> Resend unmodified as list approval for linux-cachefs@r.c timed out.
> 
> diff --git a/fs/fscache/main.c b/fs/fscache/main.c
> index c1e6cc9091aa..ccb06dc0a6e9 100644
> --- a/fs/fscache/main.c
> +++ b/fs/fscache/main.c
> @@ -22,19 +22,19 @@ MODULE_LICENSE("GPL");
>  unsigned fscache_defer_lookup = 1;
>  module_param_named(defer_lookup, fscache_defer_lookup, uint,
>  		   S_IWUSR | S_IRUGO);
> -MODULE_PARM_DESC(fscache_defer_lookup,
> +MODULE_PARM_DESC(defer_lookup,
>  		 "Defer cookie lookup to background thread");
>  
>  unsigned fscache_defer_create = 1;
>  module_param_named(defer_create, fscache_defer_create, uint,
>  		   S_IWUSR | S_IRUGO);
> -MODULE_PARM_DESC(fscache_defer_create,
> +MODULE_PARM_DESC(defer_create,
>  		 "Defer cookie creation to background thread");
>  
>  unsigned fscache_debug;
>  module_param_named(debug, fscache_debug, uint,
>  		   S_IWUSR | S_IRUGO);
> -MODULE_PARM_DESC(fscache_debug,
> +MODULE_PARM_DESC(debug,
>  		 "FS-Cache debugging mask");
>  
>  struct kobject *fscache_root;
> -- 
> 2.30.1

David,  I got no feedback on this here, yet.  Shall I fix something or 
is there anything wrong with the patch?  

Kind regards,
Nicolas

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)