linux-kernel - Re: [PATCH][next] hugetlb: Fix spelling mistake "hierarichal" -> "hierarchical"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dcd6ed6a-a915-49b5-a428-f21f2e3e3e00@gmail.com>
Date:   Fri, 26 Nov 2021 08:29:59 +0000
From:   "Colin King (gmail)" <colin.i.king@...glemail.com>
To:     Joe Perches <joe@...ches.com>,
        Colin Ian King <colin.i.king@...glemail.com>,
        Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] hugetlb: Fix spelling mistake "hierarichal" ->
 "hierarchical"

On 26/11/2021 08:15, Joe Perches wrote:
> On Thu, 2021-11-25 at 09:06 +0000, Colin Ian King wrote:
>> There is a spelling mistake in a literal string and a comment. Fix them.
> []
>> diff --git a/mm/hugetlb_cgroup.c b/mm/hugetlb_cgroup.c
> []
>> @@ -495,11 +495,11 @@ static int hugetlb_cgroup_read_numa_stat(struct seq_file *seq, void *dummy)
>>   	 * The hierarchical total is pretty much the value recorded by the
>>   	 * counter, so use that.
>>   	 */
>> -	seq_printf(seq, "%stotal=%lu", legacy ? "hierarichal_" : "",
>> +	seq_printf(seq, "%stotal=%lu", legacy ? "hierarchical_" : "",
>>   		   page_counter_read(&h_cg->hugepage[idx]) * PAGE_SIZE);
> 
> Not sure this should be changed as seq output is nominally ABI.

This just landed in linux-next, so I doubt many folk are using it. Let's 
fix it before it lands mainline.

> 
>>   
>>   	/*
>> -	 * For each node, transverse the css tree to obtain the hierarichal
>> +	 * For each node, transverse the css tree to obtain the hierarchical
> 
> Fixing the comment typo is good.  Thanks.
> 
>