linux-kernel - RE: [EXT] [PATCH 1/2] scsi: qedi: Remove set but unused 'page' variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CO6PR18MB44199C2AE98B79EE9D46D679D8639@CO6PR18MB4419.namprd18.prod.outlook.com>
Date:   Fri, 26 Nov 2021 08:52:29 +0000
From:   Manish Rangankar <mrangankar@...vell.com>
To:     Florian Fainelli <f.fainelli@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     kernel test robot <lkp@...el.com>,
        Nilesh Javali <njavali@...vell.com>,
        GR-QLogic-Storage-Upstream <GR-QLogic-Storage-Upstream@...vell.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        "open list:QLOGIC QL41xxx ISCSI DRIVER" <linux-scsi@...r.kernel.org>
Subject: RE: [EXT] [PATCH 1/2] scsi: qedi: Remove set but unused 'page'
 variable



> -----Original Message-----
> From: Florian Fainelli <f.fainelli@...il.com>
> Sent: Friday, November 26, 2021 10:45 AM
> To: linux-kernel@...r.kernel.org
> Cc: Florian Fainelli <f.fainelli@...il.com>; kernel test robot <lkp@...el.com>;
> Nilesh Javali <njavali@...vell.com>; Manish Rangankar
> <mrangankar@...vell.com>; GR-QLogic-Storage-Upstream <GR-QLogic-
> Storage-Upstream@...vell.com>; James E.J. Bottomley <jejb@...ux.ibm.com>;
> Martin K. Petersen <martin.petersen@...cle.com>; open list:QLOGIC QL41xxx
> ISCSI DRIVER <linux-scsi@...r.kernel.org>
> Subject: [EXT] [PATCH 1/2] scsi: qedi: Remove set but unused 'page' variable
> 
> External Email
> 
> ----------------------------------------------------------------------
> The variable page is set but never used throughout qedi_alloc_bdq() therefore
> remove it.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> ---
>  drivers/scsi/qedi/qedi_main.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c index
> 1dec814d8788..f1c933070884 100644
> --- a/drivers/scsi/qedi/qedi_main.c
> +++ b/drivers/scsi/qedi/qedi_main.c
> @@ -1538,7 +1538,6 @@ static int qedi_alloc_bdq(struct qedi_ctx *qedi)
>  	int i;
>  	struct scsi_bd *pbl;
>  	u64 *list;
> -	dma_addr_t page;
> 
>  	/* Alloc dma memory for BDQ buffers */
>  	for (i = 0; i < QEDI_BDQ_NUM; i++) {
> @@ -1608,11 +1607,9 @@ static int qedi_alloc_bdq(struct qedi_ctx *qedi)
>  	qedi->bdq_pbl_list_num_entries = qedi->bdq_pbl_mem_size /
>  					 QEDI_PAGE_SIZE;
>  	list = (u64 *)qedi->bdq_pbl_list;
> -	page = qedi->bdq_pbl_list_dma;
>  	for (i = 0; i < qedi->bdq_pbl_list_num_entries; i++) {
>  		*list = qedi->bdq_pbl_dma;
>  		list++;
> -		page += QEDI_PAGE_SIZE;
>  	}
> 
>  	return 0;
> --
> 2.25.1

Thanks,
Acked-by: Manish Rangankar <mrangankar@...vell.com>