linux-kernel - Re: [PATCH -next] mac80211: fix suspicious RCU usage in ieee80211_set_tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f0835218828401ed49ceacbb62c62284f4d99d95.camel@sipsolutions.net>
Date:   Fri, 26 Nov 2021 13:02:42 +0100
From:   Johannes Berg <johannes@...solutions.net>
To:     Bixuan Cui <cuibixuan@...ux.alibaba.com>,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        linux-wireless@...r.kernel.org
Cc:     davem@...emloft.ne, kuba@...nel.org
Subject: Re: [PATCH -next] mac80211: fix suspicious RCU usage in
 ieee80211_set_tx_power()

On Mon, 2021-11-15 at 14:09 +0800, Bixuan Cui wrote:
> 
> diff --git a/net/mac80211/cfg.c b/net/mac80211/cfg.c
> index 1ab8483..14fbe9e 100644
> --- a/net/mac80211/cfg.c
> +++ b/net/mac80211/cfg.c
> @@ -2702,14 +2702,19 @@ static int ieee80211_set_tx_power(struct wiphy *wiphy,
>  	enum nl80211_tx_power_setting txp_type = type;
>  	bool update_txp_type = false;
>  	bool has_monitor = false;
> +	int ret = 0;
> +
> +	rtnl_lock();
> 

This will almost certainly result in lockups, or at least lockdep
complaints, that's just wrong.

johannes