linux-kernel - Re: [PATCH] scripts/tags: merge "TAGS" and "tags" in case

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YaEECIyT3LT7JQzQ@kroah.com>
Date:   Fri, 26 Nov 2021 16:58:00 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Zhaoyu Liu <zackary.liu.pro@...il.com>
Cc:     masahiroy@...nel.org, ripxorip@...il.com, mpe@...erman.id.au,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scripts/tags: merge "TAGS" and "tags" in case

On Wed, Nov 03, 2021 at 11:35:29PM +0800, Zhaoyu Liu wrote:
> merge "TAGS" and "tags" for the code more concise
> 
> Signed-off-by: Zhaoyu Liu <zackary.liu.pro@...il.com>
> ---
>  scripts/tags.sh | 14 +++++---------
>  1 file changed, 5 insertions(+), 9 deletions(-)
> 
> diff --git a/scripts/tags.sh b/scripts/tags.sh
> index 16d475b3e203..a9181dd0fee2 100755
> --- a/scripts/tags.sh
> +++ b/scripts/tags.sh
> @@ -315,15 +315,11 @@ case "$1" in
>  		dogtags
>  		;;
>  
> -	"tags")
> -		rm -f tags
> -		xtags ctags
> -		remove_structs=y
> -		;;
> -
> -	"TAGS")
> -		rm -f TAGS
> -		xtags etags
> +	"TAGS" | "tags")
> +		rm -f $1
> +		xtags $([ $1 = "tags" ]	\
> +			&& echo ctags		\
> +			|| echo etags)
>  		remove_structs=y
>  		;;

Ick, that's much harder to read and understand.

What is wrong with the existing code?  It's obvious and makes sense, it
is not duplicating any lines here except the one "remove_structs=y"
which is fine.

I'm not going to take this, sorry.

greg k-h