linux-kernel - Re: [PATCH] ARM: dts: sun8i: Adjust power key nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211126162558.5wkiy2bdmeutn7e7@houat>
Date:   Fri, 26 Nov 2021 17:25:58 +0100
From:   Maxime Ripard <maxime@...no.tech>
To:     Jernej Škrabec <jernej.skrabec@...il.com>
Cc:     wens@...e.org, robh+dt@...nel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev,
        linux-kernel@...r.kernel.org, Michael Klein <michael@...sekall.de>
Subject: Re: [PATCH] ARM: dts: sun8i: Adjust power key nodes

On Tue, Nov 23, 2021 at 05:42:55PM +0100, Jernej Škrabec wrote:
> Hi!
> 
> Dne torek, 23. november 2021 ob 11:32:19 CET je Maxime Ripard napisal(a):
> > Hi,
> > 
> > On Mon, Nov 22, 2021 at 10:36:37PM +0100, Jernej Skrabec wrote:
> > > Several H3 and one H2+ board have power key nodes, which are slightly
> > > off. Some are missing wakeup-source property and some have BTN_0 code
> > > assigned instead of KEY_POWER.
> > > 
> > > Adjust them, so they can function as intended by designer.
> > > 
> > > Signed-off-by: Jernej Skrabec <jernej.skrabec@...il.com>
> > > [BananaPi M2 Zero changes]
> > > Signed-off-by: Michael Klein <michael@...sekall.de>
> > 
> > This looks a bit weird. If Michael is the author, then his SoB should be
> > here first and mentioned either in From or Co-developed-by.
> > 
> > If you are, I'm not sure why he's mentioned?
> 
> I'm main author and Michael just adapted BananaPi M2 Zero DT based on my 
> changes. What is preferred way to mark him as co-author?

Co-developed-by would be the way to go then

Maxime

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)