linux-kernel - RE: [PATCH] ACPICA: fix swap.cocci warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 27 Nov 2021 11:36:11 +0000
From:   "Moore, Robert" <robert.moore@...el.com>
To:     Guo Zhengkui <guozhengkui@...o.com>,
        "Rafael J. Wysocki" <rafael@...nel.org>
CC:     "Wysocki, Rafael J" <rafael.j.wysocki@...el.com>,
        Len Brown <lenb@...nel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        "open list:ACPI COMPONENT ARCHITECTURE (ACPICA)" <devel@...ica.org>,
        "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
        kernel <kernel@...o.com>
Subject: RE: [PATCH] ACPICA: fix swap.cocci warning



-----Original Message-----
From: Guo Zhengkui <guozhengkui@...o.com> 
Sent: Thursday, November 18, 2021 10:31 PM
To: Rafael J. Wysocki <rafael@...nel.org>
Cc: Moore, Robert <robert.moore@...el.com>; Wysocki, Rafael J <rafael.j.wysocki@...el.com>; Len Brown <lenb@...nel.org>; ACPI Devel Maling List <linux-acpi@...r.kernel.org>; open list:ACPI COMPONENT ARCHITECTURE (ACPICA) <devel@...ica.org>; Linux Kernel Mailing List <linux-kernel@...r.kernel.org>; kernel <kernel@...o.com>
Subject: Re: [PATCH] ACPICA: fix swap.cocci warning

On 2021/11/18 22:46, Rafael J. Wysocki wrote:
> On Tue, Nov 9, 2021 at 2:47 PM Guo Zhengkui <guozhengkui@...o.com> wrote:
>>
>> Fix following swap.cocci warning:
>> ./drivers/acpi/acpica/nsrepair2.c:896:33-34: WARNING opportunity for 
>> swap()
>>
>> Signed-off-by: Guo Zhengkui <guozhengkui@...o.com>
> 
> This change needs to be submitted to the upstream ACPICA project via 
> https://github.com/acpica/acpica/
> 
> Thanks!

So it means I need to submit this patch to upstream ACPICA project, not linux-next?


The answer is yes.
Bob


> 
>> ---
>>   drivers/acpi/acpica/nsrepair2.c | 6 ++----
>>   1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/acpi/acpica/nsrepair2.c 
>> b/drivers/acpi/acpica/nsrepair2.c index 14b71b41e845..02a904ca4caf 
>> 100644
>> --- a/drivers/acpi/acpica/nsrepair2.c
>> +++ b/drivers/acpi/acpica/nsrepair2.c
>> @@ -8,6 +8,7 @@
>>    *
>>    
>> *********************************************************************
>> ********/
>>
>> +#include <linux/minmax.h>
>>   #include <acpi/acpi.h>
>>   #include "accommon.h"
>>   #include "acnamesp.h"
>> @@ -875,7 +876,6 @@ acpi_ns_sort_list(union acpi_operand_object **elements,
>>   {
>>          union acpi_operand_object *obj_desc1;
>>          union acpi_operand_object *obj_desc2;
>> -       union acpi_operand_object *temp_obj;
>>          u32 i;
>>          u32 j;
>>
>> @@ -892,9 +892,7 @@ acpi_ns_sort_list(union acpi_operand_object **elements,
>>                              || ((sort_direction == ACPI_SORT_DESCENDING)
>>                                  && (obj_desc1->integer.value <
>>                                      obj_desc2->integer.value))) {
>> -                               temp_obj = elements[j - 1];
>> -                               elements[j - 1] = elements[j];
>> -                               elements[j] = temp_obj;
>> +                               swap(elements[j - 1], elements[j]);
>>                          }
>>                  }
>>          }
>> --
>> 2.20.1
>>