linux-kernel - Re: [PATCH] iio: trigger: stm32-timer: fix MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211127174602.6f674d37@jic23-huawei>
Date:   Sat, 27 Nov 2021 17:46:02 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Alyssa Ross <hi@...ssa.is>
Cc:     Lars-Peter Clausen <lars@...afoo.de>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Benjamin Gaignard <benjamin.gaignard@...aro.org>,
        Lee Jones <lee.jones@...aro.org>,
        linux-iio@...r.kernel.org (open list:IIO SUBSYSTEM AND DRIVERS),
        linux-stm32@...md-mailman.stormreply.com (moderated list:ARM/STM32
        ARCHITECTURE),
        linux-arm-kernel@...ts.infradead.org (moderated list:ARM/STM32
        ARCHITECTURE), linux-kernel@...r.kernel.org (open list)
Subject: Re: [PATCH] iio: trigger: stm32-timer: fix MODULE_ALIAS

On Thu, 25 Nov 2021 18:28:48 +0000
Alyssa Ross <hi@...ssa.is> wrote:

> modprobe can't handle spaces in aliases.
> 
> Fixes: 93fbe91b5521 ("iio: Add STM32 timer trigger driver")
> Signed-off-by: Alyssa Ross <hi@...ssa.is>
Hi Alysaa,

Looks fine to me, but I'd like to give it a little longer on list before
taking it as a fix, particularly as this probably wants to get backported
to stable.

Thanks,

Jonathan

> ---
>  drivers/iio/trigger/stm32-timer-trigger.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/trigger/stm32-timer-trigger.c b/drivers/iio/trigger/stm32-timer-trigger.c
> index 33083877cd19..4353b749ecef 100644
> --- a/drivers/iio/trigger/stm32-timer-trigger.c
> +++ b/drivers/iio/trigger/stm32-timer-trigger.c
> @@ -912,6 +912,6 @@ static struct platform_driver stm32_timer_trigger_driver = {
>  };
>  module_platform_driver(stm32_timer_trigger_driver);
>  
> -MODULE_ALIAS("platform: stm32-timer-trigger");
> +MODULE_ALIAS("platform:stm32-timer-trigger");
>  MODULE_DESCRIPTION("STMicroelectronics STM32 Timer Trigger driver");
>  MODULE_LICENSE("GPL v2");