linux-kernel - Re: [PATCH v6 2/3] dt-bindings: iio: add AD74413R

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211127185556.5d91fd83@jic23-huawei>
Date:   Sat, 27 Nov 2021 18:55:56 +0000
From:   Jonathan Cameron <jic23@...nel.org>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Cosmin Tanislav <demonsingur@...il.com>,
        cosmin.tanislav@...log.com, Lars-Peter Clausen <lars@...afoo.de>,
        Michael Hennerich <michael.hennerich@...log.com>,
        Rob Herring <robh+dt@...nel.org>, linux-iio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Bartosz Golaszewski <brgl@...ev.pl>, linux-gpio@...r.kernel.org
Subject: Re: [PATCH v6 2/3] dt-bindings: iio: add AD74413R

On Sat, 27 Nov 2021 02:23:26 +0100
Linus Walleij <linus.walleij@...aro.org> wrote:

> On Fri, Nov 26, 2021 at 5:03 PM Cosmin Tanislav <demonsingur@...il.com> wrote:
> 
> > +  adi,rsense-resistance-ohms:
> > +    description:
> > +      RSense resistance values in Ohms.  
> 
> This description is very terse. If it is existing for the same purpose as
> shunt-resistor-micro-ohms in
> Documentation/devicetree/bindings/iio/afe/current-sense-shunt.yaml
> then you should just recycle the standard binding
> shunt-resistor-micro-ohms instead of inventing this custom one.

Good point.  I'd forgotten about that one.  We had to make that generic
as a current sense shunt inherently doesn't have a vendor :)

Thanks Linus!

Jonathan
> 
> Yours,
> Linus Walleij