linux-kernel - Re: [PATCH] hv: utils: add PTP_1588

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <8752eeae-6280-310e-85f1-bc0e594202fc@infradead.org>
Date:   Sun, 28 Nov 2021 14:49:32 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Wei Liu <wei.liu@...nel.org>,
        "Michael Kelley (LINUX)" <mikelley@...rosoft.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        kernel test robot <lkp@...el.com>,
        Arnd Bergmann <arnd@...db.de>,
        KY Srinivasan <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Dexuan Cui <decui@...rosoft.com>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] hv: utils: add PTP_1588_CLOCK to Kconfig to fix build



On 11/28/21 13:26, Wei Liu wrote:
> On Sat, Nov 27, 2021 at 07:12:11PM +0000, Michael Kelley (LINUX) wrote:
>> From: Randy Dunlap <rdunlap@...radead.org> Sent: Thursday, November 25, 2021 6:33 PM
>>>
>>> The hyperv utilities use PTP clock interfaces and should depend a
>>> a kconfig symbol such that they will be built as a loadable module or
>>> builtin so that linker errors do not happen.
>>>
>>> Prevents these build errors:
>>>
>>> ld: drivers/hv/hv_util.o: in function `hv_timesync_deinit':
>>> hv_util.c:(.text+0x37d): undefined reference to `ptp_clock_unregister'
>>> ld: drivers/hv/hv_util.o: in function `hv_timesync_init':
>>> hv_util.c:(.text+0x738): undefined reference to `ptp_clock_register'
>>>
>>> Fixes: 46a971913611a ("Staging: hv: move hyperv code out of staging directory")
>>
>> Seems like the "Fixes" tag should reference something a little newer than
>> when the Hyper-V code was first added.  Either commit 3716a49a81ba
>> ("hv_utils: implement Hyper-V PTP source") or commit e5f31552674e
>> ("ethernet: fix PTP_1588_CLOCK dependencies") when
>> PTP_1588_CLOCK_OPTIONAL was added.
> [...]
>>
>> Reviewed-by: Michael Kelley <mikelley@...rosoft.com>
> 
> I used 3716a49a81ba in the Fixes tag and pushed it to hyperv-fixes.
> 
> Wei.

Oh, thank you.

~Randy