linux-kernel - Re: [PATCH] watchdog: da9063: Add hard dependency on I2C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20211129153234.GA2627247@roeck-us.net>
Date:   Mon, 29 Nov 2021 07:32:34 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Andrej Picej <andrej.picej@...ik.com>
Cc:     wim@...ux-watchdog.org, linux-watchdog@...r.kernel.org,
        y.bas@...tec.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] watchdog: da9063: Add hard dependency on I2C

On Mon, Nov 29, 2021 at 02:49:38PM +0100, Andrej Picej wrote:
> Commit 5ea29919c294 ("watchdog: da9063: use atomic safe i2c transfer in
> reset handler") implements atomic save i2c transfer which uses i2c
> functions directly. Add I2C hard dependency which overrides COMPILE_TEST.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Fixes: 5ea29919c294 ("watchdog: da9063: use atomic safe i2c transfer in reset handler")
> Signed-off-by: Andrej Picej <andrej.picej@...ik.com>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>  drivers/watchdog/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index 9d222ba17ec6..3207085f799f 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -207,6 +207,7 @@ config DA9055_WATCHDOG
>  config DA9063_WATCHDOG
>  	tristate "Dialog DA9063 Watchdog"
>  	depends on MFD_DA9063 || COMPILE_TEST
> +	depends on I2C
>  	select WATCHDOG_CORE
>  	help
>  	  Support for the watchdog in the DA9063 PMIC.
> -- 
> 2.25.1
>