linux-kernel - Re: [PATCH] i2c: designware: Get HCNT/LCNT values from dts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YaUp2pFmrDJhv4T+@kunai>
Date:   Mon, 29 Nov 2021 20:28:26 +0100
From:   Wolfram Sang <wsa@...nel.org>
To:     "Lawrence,Wang" <lawrence.wang@...ia-sbell.com>
Cc:     jarkko.nikula@...ux.intel.com, andriy.shevchenko@...ux.intel.com,
        mika.westerberg@...ux.intel.com, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org, Wang@...inb193.emea.nsn-net.net
Subject: Re: [PATCH] i2c: designware: Get HCNT/LCNT values from dts


> +	ret = device_property_read_u16_array(dev->dev, "dw-i2c-scl-timing",
> +					(u16 *)&i2c_scl_timing, sizeof(i2c_scl_timing)/sizeof(u16));

Putting hex values directly into DT is not a proper binding. They need
to be more generic. Sadly, I don't know the DW hardware, so I can't be
of much more help. But Andy already gave some pointers, as I saw.


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)