linux-kernel - Re: [PATCH v1 1/2] i2c: designware-pci: Add support for Fast Mode Plus and High Speed Mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 29 Nov 2021 17:56:55 +0100
From:   Wolfram Sang <wsa@...nel.org>
To:     lakshmi.sowjanya.d@...el.com
Cc:     linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
        jarkko.nikula@...ux.intel.com, bala.senthil@...el.com,
        pandith.n@...el.com
Subject: Re: [PATCH v1 1/2] i2c: designware-pci: Add support for Fast Mode
 Plus and High Speed Mode

On Tue, Nov 09, 2021 at 04:05:51PM +0530, lakshmi.sowjanya.d@...el.com wrote:
> From: Lakshmi Sowjanya D <lakshmi.sowjanya.d@...el.com>
> 
> Add support to configure HCNT, LCNT values for Fast Mode Plus and High
> Speed Mode.
> 
> Signed-off-by: Lakshmi Sowjanya D <lakshmi.sowjanya.d@...el.com>

Applied to for-next, thanks!

> +	u32 fp_lcnt;
> +	u32 hs_lcnt;
>  	u32 sda_hold;

Short question unrelated to this patch. Why are all these u32...

>  		dev->ss_hcnt = cfg->ss_hcnt;
>  		dev->fs_hcnt = cfg->fs_hcnt;

... and the ones in dev are u16? Wouldn't it be easier if they all had
the same type?


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)