linux-kernel - Re: [PATCH] tpm: make const pointer desc a static const array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <455f66b569d81606e05775c4ac04a4b16e4c1782.camel@kernel.org>
Date:   Mon, 29 Nov 2021 22:09:33 +0200
From:   Jarkko Sakkinen <jarkko@...nel.org>
To:     Colin Ian King <colin.i.king@...glemail.com>,
        Peter Huewe <peterhuewe@....de>,
        Jason Gunthorpe <jgg@...pe.ca>, linux-integrity@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tpm: make const pointer desc a static const array

On Sat, 2021-11-27 at 17:26 +0000, Colin Ian King wrote:
> Make const pointer desc a static const array, removes a dereference
> and shrinks object code a few bytes.
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
>  drivers/char/tpm/tpm_tis_core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm/tpm_tis_core.c
> index b2659a4c4016..649b4229e76e 100644
> --- a/drivers/char/tpm/tpm_tis_core.c
> +++ b/drivers/char/tpm/tpm_tis_core.c
> @@ -716,7 +716,7 @@ static irqreturn_t tis_int_handler(int dummy, void *dev_id)
>  
>  static int tpm_tis_gen_interrupt(struct tpm_chip *chip)
>  {
> -       const char *desc = "attempting to generate an interrupt";
> +       static const char desc[] = "attempting to generate an interrupt";
>         u32 cap2;
>         cap_t cap;
>         int ret;

I'd rather go for:

#define TPM_TIS_GEN_INTERRUPT_DESC "attempting to generate an interrupt"

/Jarkko