linux-kernel - RE: [EXT] [PATCH v2 2/2] scsi: qedi: Fix SYSFS_FLAG_FW_SEL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CO6PR18MB4419B4245BB9ED3387105444D8669@CO6PR18MB4419.namprd18.prod.outlook.com>
Date:   Mon, 29 Nov 2021 07:29:19 +0000
From:   Manish Rangankar <mrangankar@...vell.com>
To:     Florian Fainelli <f.fainelli@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     kernel test robot <lkp@...el.com>,
        Nilesh Javali <njavali@...vell.com>,
        GR-QLogic-Storage-Upstream <GR-QLogic-Storage-Upstream@...vell.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        "open list:QLOGIC QL41xxx ISCSI DRIVER" <linux-scsi@...r.kernel.org>
Subject: RE: [EXT] [PATCH v2 2/2] scsi: qedi: Fix SYSFS_FLAG_FW_SEL_BOOT
 formatting



> -----Original Message-----
> From: Florian Fainelli <f.fainelli@...il.com>
> Sent: Saturday, November 27, 2021 1:47 AM
> To: linux-kernel@...r.kernel.org
> Cc: Florian Fainelli <f.fainelli@...il.com>; kernel test robot <lkp@...el.com>;
> Nilesh Javali <njavali@...vell.com>; Manish Rangankar
> <mrangankar@...vell.com>; GR-QLogic-Storage-Upstream <GR-QLogic-
> Storage-Upstream@...vell.com>; James E.J. Bottomley <jejb@...ux.ibm.com>;
> Martin K. Petersen <martin.petersen@...cle.com>; open list:QLOGIC QL41xxx
> ISCSI DRIVER <linux-scsi@...r.kernel.org>
> Subject: [EXT] [PATCH v2 2/2] scsi: qedi: Fix SYSFS_FLAG_FW_SEL_BOOT
> formatting
> 
> External Email
> 
> ----------------------------------------------------------------------
> The format used for formatting SYSFS_FLAG_FW_SEL_BOOT creates the
> following warning:
> 
> drivers/scsi/qedi/qedi_main.c:2259:35: warning: format specifies type 'char' but
> the argument has type 'int' [-Wformat]
>                    rc = snprintf(buf, 3, "%hhd\n", SYSFS_FLAG_FW_SEL_BOOT);
> 
> Fix this to cast the constant as an u8 since the intention is to print it via sysfs as a
> byte.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> ---
>  drivers/scsi/qedi/qedi.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/qedi/qedi.h b/drivers/scsi/qedi/qedi.h index
> ce199a7a16b8..421b3a69fd37 100644
> --- a/drivers/scsi/qedi/qedi.h
> +++ b/drivers/scsi/qedi/qedi.h
> @@ -358,7 +358,7 @@ struct qedi_ctx {
>  	bool use_fast_sge;
> 
>  	atomic_t num_offloads;
> -#define SYSFS_FLAG_FW_SEL_BOOT 2
> +#define SYSFS_FLAG_FW_SEL_BOOT (u8)2
>  #define IPV6_LEN	41
>  #define IPV4_LEN	17
>  	struct iscsi_boot_kset *boot_kset;
> --
> 2.25.1

Acked-by: Manish Rangankar <mrangankar@...vell.com>