[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <F7C7AB2A-50B8-453C-92B2-38273B5173BB@live.com>
Date: Mon, 29 Nov 2021 08:42:53 +0000
From: Aditya Garg <gargaditya08@...e.com>
To: Marcel Holtmann <marcel@...tmann.org>
CC: Thorsten Leemhuis <regressions@...mhuis.info>,
Orlando Chamberlain <redecorating@...tonmail.com>,
Daniel Winkler <danielwinkler@...gle.com>,
Greg KH <gregkh@...uxfoundation.org>,
Johan Hedberg <johan.hedberg@...el.com>,
"linux-bluetooth@...r.kernel.org" <linux-bluetooth@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Luiz Augusto von Dentz <luiz.dentz@...il.com>,
"regressions@...ts.linux.dev" <regressions@...ts.linux.dev>,
"sonnysasaka@...omium.org" <sonnysasaka@...omium.org>,
"stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: Re: [PATCH 2/6] btbcm: disable read tx power for MacBook Pro 16,1 (16
inch, 2019)
> On 29-Nov-2021, at 1:52 PM, Marcel Holtmann <marcel@...tmann.org> wrote:
>
> Hi Aditya,
>
>>>> Bluetooth on Apple MacBook Pro 16,1 is unable to start due to LE Min/Max Tx Power being queried on startup. Add a DMI based quirk so that it is disabled.
>>>
>>> list all the MacBooks that you found problematic right now. We add the
>>> initial as a large batch instead of all individual.
>>>
>>>>
>>>> Signed-off-by: Aditya Garg <gargaditya08@...e.com>
>>>> Tested-by: Aditya Garg <gargaditya08@...e.com>
>>>> ---
>>>> drivers/bluetooth/btbcm.c | 20 ++++++++++++++++++++
>>>> 1 file changed, 20 insertions(+)
>>>>
>>>> diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c
>>>> index e4182acee488c5..c1b0ca63880a68 100644
>>>> --- a/drivers/bluetooth/btbcm.c
>>>> +++ b/drivers/bluetooth/btbcm.c
>>>> @@ -8,6 +8,7 @@
>>>>
>>>> #include <linux/module.h>
>>>> #include <linux/firmware.h>
>>>> +#include <linux/dmi.h>
>>>> #include <asm/unaligned.h>
>>>>
>>>> #include <net/bluetooth/bluetooth.h>
>>>> @@ -343,9 +344,23 @@ static struct sk_buff *btbcm_read_usb_product(struct hci_dev *hdev)
>>>> return skb;
>>>> }
>>>>
>>>> +static const struct dmi_system_id disable_broken_read_transmit_power[] = {
>>>> + {
>>>> + /* Match for Apple MacBook Pro 16,1 which needs
>>>> + * Read LE Min/Max Tx Power to be disabled.
>>>> + */
>>>
>>> Actually leave the comment out. You are not adding any value that isn’t
>>> already in the variable name or the DMI. It is just repeating the obvious.
>> Alright, I prepare the patches into a single one
>
> two patches, one for adding the quirk to the core and one for adjusting the driver.
Sent
>
> Regards
>
> Marcel
>
Powered by blists - more mailing lists