linux-kernel - Re: [PATCH] tee: amdtee: fix an IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20211129085404.GQ18178@kadam>
Date:   Mon, 29 Nov 2021 11:54:04 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     994605959 <994605959@...com>
Cc:     "Rijo-john.Thomas@....com" <Rijo-john.Thomas@....com>,
        "jens.wiklander@...aro.org" <jens.wiklander@...aro.org>,
        "Devaraj.Rangasamy@....com" <Devaraj.Rangasamy@....com>,
        "herbert@...dor.apana.org.au" <herbert@...dor.apana.org.au>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "gary.hook@....com" <gary.hook@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "op-tee@...ts.trustedfirmware.org" <op-tee@...ts.trustedfirmware.org>
Subject: Re: [PATCH] tee: amdtee: fix an IS_ERR() vs NULL bug

On Mon, Nov 29, 2021 at 04:31:51PM +0800, 994605959 wrote:
>    maybe try this?
>    -  if (IS_ERR(*ta)) {
>    -    pr_err("%s: get_free_pages failed 0x%llx\n", __func__,
>    -           (u64)*ta);
>    +  if (IS_ERR(ta)) {
>    +    pr_err("%s: get_free_pages failed %p\n", __func__, ta);


No, what you are suggesting is totally wrong.  You are checking the
wrong variable for the wrong thing.

regards,
dan carpenter