linux-kernel - Re: [tip:core/entry 9/11] arch/powerpc/kernel/interrupt.c:151:64: error: passing argument 2 of 'set_bits' makes pointer from integer without a cast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YaShuNUwpTQRl6je@FVFF77S0Q05N>
Date:   Mon, 29 Nov 2021 09:48:18 +0000
From:   Mark Rutland <mark.rutland@....com>
To:     kernel test robot <lkp@...el.com>,
        Thomas Gleixner <tglx@...utronix.de>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        x86@...nel.org
Subject: Re: [tip:core/entry 9/11] arch/powerpc/kernel/interrupt.c:151:64:
 error: passing argument 2 of 'set_bits' makes pointer from integer without a
 cast

On Sat, Nov 27, 2021 at 11:03:48AM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git core/entry
> head:   5796ee48d26a18930a8b86fb865ba195282889d0
> commit: 51ed65dcfd9c61a15920a40178d471d236a7514c [9/11] powerpc: Avoid discarding flags in system_call_exception()
> config: powerpc-allnoconfig (https://download.01.org/0day-ci/archive/20211127/202111271105.v7pE3REd-lkp@intel.com/config)
> compiler: powerpc-linux-gcc (GCC) 11.2.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?id=51ed65dcfd9c61a15920a40178d471d236a7514c
>         git remote add tip https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
>         git fetch --no-tags tip core/entry
>         git checkout 51ed65dcfd9c61a15920a40178d471d236a7514c
>         # save the config file to linux build tree
>         mkdir build_dir
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=powerpc SHELL=/bin/bash arch/powerpc/kernel/
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@...el.com>
> 
> All errors (new ones prefixed by >>):
> 
>    arch/powerpc/kernel/interrupt.c: In function 'system_call_exception':
> >> arch/powerpc/kernel/interrupt.c:151:64: error: passing argument 2 of 'set_bits' makes pointer from integer without a cast [-Werror=int-conversion]
>      151 |                 set_bits(_TIF_RESTOREALL, current_thread_info()->flags);
>    In file included from include/linux/bitops.h:33,
>                     from include/linux/log2.h:12,
>                     from include/asm-generic/div64.h:55,
>                     from ./arch/powerpc/include/generated/asm/div64.h:1,
>                     from include/linux/math.h:5,
>                     from include/linux/math64.h:6,
>                     from include/linux/time64.h:5,
>                     from include/linux/restart_block.h:10,
>                     from include/linux/thread_info.h:14,
>                     from arch/powerpc/include/asm/ptrace.h:323,
>                     from arch/powerpc/include/asm/hw_irq.h:12,
>                     from arch/powerpc/include/asm/irqflags.h:12,
>                     from include/linux/irqflags.h:16,
>                     from include/asm-generic/cmpxchg-local.h:6,
>                     from arch/powerpc/include/asm/cmpxchg.h:526,
>                     from arch/powerpc/include/asm/atomic.h:11,
>                     from include/linux/atomic.h:7,
>                     from include/linux/rcupdate.h:25,
>                     from include/linux/rculist.h:11,
>                     from include/linux/pid.h:5,
>                     from include/linux/sched.h:14,
>                     from include/linux/context_tracking.h:5,
>                     from arch/powerpc/kernel/interrupt.c:3:
>    arch/powerpc/include/asm/bitops.h:67:41: note: expected 'volatile long unsigned int *' but argument is of type 'long unsigned int'
>       67 |                 volatile unsigned long *_p)     \
>          |                 ~~~~~~~~~~~~~~~~~~~~~~~~^~
>    arch/powerpc/include/asm/bitops.h:82:1: note: in expansion of macro 'DEFINE_BITOP'
>       82 | DEFINE_BITOP(set_bits, or, "")
>          | ^~~~~~~~~~~~
>    cc1: all warnings being treated as errors
> 
> 
> vim +/set_bits +151 arch/powerpc/kernel/interrupt.c

>    149		if (IS_ENABLED(CONFIG_PPC_TRANSACTIONAL_MEM) &&
>    150				unlikely(MSR_TM_TRANSACTIONAL(regs->msr)))
>  > 151			set_bits(_TIF_RESTOREALL, current_thread_info()->flags);

I missed a `&` in my patch, and the above should have been:
	
	set_bits(_TIF_RESTOREALL, &current_thread_info()->flags);

Thomas, should I respin the series with that corrected, send a fixup patch to
apply atop, or would you prefer to fix the commit locally?

Thanks,
Mark.