[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <163818267468.17830.10879517625736881759.kvalo@codeaurora.org>
Date: Mon, 29 Nov 2021 10:44:41 +0000 (UTC)
From: Kalle Valo <kvalo@...eaurora.org>
To: Kees Cook <keescook@...omium.org>
Cc: Kees Cook <keescook@...omium.org>,
"David S. Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>, linux-kernel@...r.kernel.org,
libertas-dev@...ts.infradead.org, linux-wireless@...r.kernel.org,
netdev@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH] libertas: Use struct_group() for memcpy() region
Kees Cook <keescook@...omium.org> wrote:
> In preparation for FORTIFY_SOURCE performing compile-time and run-time
> field bounds checking for memcpy(), memmove(), and memset(), avoid
> intentionally writing across neighboring fields.
>
> Use struct_group() in struct txpd around members tx_dest_addr_high
> and tx_dest_addr_low so they can be referenced together. This will
> allow memcpy() and sizeof() to more easily reason about sizes, improve
> readability, and avoid future warnings about writing beyond the end
> of queue_id.
>
> "pahole" shows no size nor member offset changes to struct txpd.
> "objdump -d" shows no object code changes.
>
> Signed-off-by: Kees Cook <keescook@...omium.org>
Patch applied to wireless-drivers-next.git, thanks.
5fd32ae0433a libertas: Use struct_group() for memcpy() region
--
https://patchwork.kernel.org/project/linux-wireless/patch/20211118184104.1283637-1-keescook@chromium.org/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Powered by blists - more mailing lists