linux-kernel - Re: [PATCH net] net: stmmac: Avoid DMA_CHAN_CONTROL write if no Split Header support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <163818840918.20614.10733400123125984165.git-patchwork-notify@kernel.org>
Date:   Mon, 29 Nov 2021 12:20:09 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Vincent Whitchurch <vincent.whitchurch@...s.com>
Cc:     peppe.cavallaro@...com, alexandre.torgue@...s.st.com,
        joabreu@...opsys.com, davem@...emloft.net, kuba@...nel.org,
        mcoquelin.stm32@...il.com, kernel@...s.com,
        Jose.Abreu@...opsys.com, netdev@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: stmmac: Avoid DMA_CHAN_CONTROL write if no Split
 Header support

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@...emloft.net>:

On Fri, 26 Nov 2021 16:51:15 +0100 you wrote:
> The driver assumes that split headers can be enabled/disabled without
> stopping/starting the device, so it writes DMA_CHAN_CONTROL from
> stmmac_set_features().  However, on my system (IP v5.10a without Split
> Header support), simply writing DMA_CHAN_CONTROL when DMA is running
> (for example, with the commands below) leads to a TX watchdog timeout.
> 
>  host$ socat TCP-LISTEN:1024,fork,reuseaddr - &
>  device$ ethtool -K eth0 tso off
>  device$ ethtool -K eth0 tso on
>  device$ dd if=/dev/zero bs=1M count=10 | socat - TCP4:host:1024
>  <tx watchdog timeout>
> 
> [...]

Here is the summary with links:
  - [net] net: stmmac: Avoid DMA_CHAN_CONTROL write if no Split Header support
    https://git.kernel.org/netdev/net/c/f8e7dfd6fdab

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html