linux-kernel - Re: [PATCH] drm/tidss: Fix warning: unused variable 'tidss_pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bc1a7d47-2afc-9385-d465-4d7fc1c59b21@ideasonboard.com>
Date:   Mon, 29 Nov 2021 13:13:23 +0200
From:   Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
To:     Cai Huoqing <caihuoqing@...du.com>
Cc:     Jyri Sarha <jyri.sarha@....fi>, David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/tidss: Fix warning: unused variable 'tidss_pm_ops'

On 29/11/2021 08:33, Cai Huoqing wrote:
> Mark 'tidss_pm_ops' as __maybe_unused to avoid
> the warning: unused variable 'tidss_pm_ops'
> 
> Fixes: 6e120594631f ("drm/tidss: Make use of the helper macro SET_RUNTIME_PM_OPS()")
> Signed-off-by: Cai Huoqing <caihuoqing@...du.com>
> ---
>   drivers/gpu/drm/tidss/tidss_drv.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/tidss/tidss_drv.c b/drivers/gpu/drm/tidss/tidss_drv.c
> index 4366b5c798e0..7c784e90e40e 100644
> --- a/drivers/gpu/drm/tidss/tidss_drv.c
> +++ b/drivers/gpu/drm/tidss/tidss_drv.c
> @@ -88,7 +88,7 @@ static int __maybe_unused tidss_resume(struct device *dev)
>   	return drm_mode_config_helper_resume(&tidss->ddev);
>   }
>   
> -static const struct dev_pm_ops tidss_pm_ops = {
> +static __maybe_unused const struct dev_pm_ops tidss_pm_ops = {
>   	SET_SYSTEM_SLEEP_PM_OPS(tidss_suspend, tidss_resume)
>   	SET_RUNTIME_PM_OPS(tidss_pm_runtime_suspend, tidss_pm_runtime_resume, NULL)
>   };

Thanks, I'll push to drm-misc-next.

  Tomi