linux-kernel - Re: [PATCH] PCI: brcmstb: Declare a bitmap as a bitmap, not as a plain 'unsigned long'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <163819142462.10670.2516167038486090067.b4-ty@arm.com>
Date:   Mon, 29 Nov 2021 13:11:45 +0000
From:   Lorenzo Pieralisi <lorenzo.pieralisi@....com>
To:     nsaenz@...nel.org, bcm-kernel-feedback-list@...adcom.com,
        f.fainelli@...il.com, robh@...nel.org, jim2101024@...il.com,
        kw@...ux.com, Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        bhelgaas@...gle.com
Cc:     Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-rpi-kernel@...ts.infradead.org
Subject: Re: [PATCH] PCI: brcmstb: Declare a bitmap as a bitmap, not as a plain 'unsigned long'

On Sun, 7 Nov 2021 09:32:58 +0100, Christophe JAILLET wrote:
> The 'used' field of 'struct brcm_msi' is used as a bitmap. So it should
> be declared as so (i.e. unsigned long *).
> 
> This fixes an harmless Coverity warning about array vs singleton usage.
> 
> This bitmap can be BRCM_INT_PCI_MSI_LEGACY_NR or BRCM_INT_PCI_MSI_NR long.
> So, while at it, document it, should it help someone in the future.

Applied to pci/brcmstb, thanks!

[1/1] PCI: brcmstb: Declare a bitmap as a bitmap, not as a plain 'unsigned long'
      https://git.kernel.org/lpieralisi/pci/c/3e46790d16

Thanks,
Lorenzo