linux-kernel - Re: [PATCH 3/3] i2c: stm32f7: prevent calling slave handling if no slave running

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YaTFsV0sIU6BA0ja@kunai>
Date:   Mon, 29 Nov 2021 13:21:05 +0100
From:   Wolfram Sang <wsa@...nel.org>
To:     Alain Volmat <alain.volmat@...s.st.com>
Cc:     pierre-yves.mordret@...s.st.com, alexandre.torgue@...s.st.com,
        linux-i2c@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        fabrice.gasnier@...s.st.com, amelie.delaunay@...s.st.com
Subject: Re: [PATCH 3/3] i2c: stm32f7: prevent calling slave handling if no
 slave running

On Wed, Jun 30, 2021 at 04:11:43PM +0200, Alain Volmat wrote:
> Slave interrupt handler should only be called if there is actually
> a slave registered and running to avoid accessing an invalid pointer.
> 
> Without this commit, an OOPS can be generated due to a NULL ptr dereference
> while receiving an IT when there is no master transfer and no slave
> running:
>   - stm32f7_i2c_isr_event
>   - no master_mode hence calling stm32f7_i2c_slave_isr_event
>   - access to i2c_dev->slave_running leading to oops due to
> slave_running being NULL.
> 
> Fixes: 60d609f30de2 ("i2c: i2c-stm32f7: Add slave support")
> 
> Signed-off-by: Alain Volmat <alain.volmat@...s.st.com>

Is this one still of interest? You resent patches 1 and 2 but not this
one?


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)