linux-kernel - Re: [PATCH] PCI: xilinx-nwl: Simplify code and fix a memory leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <163819324863.26090.8890227197735152343.b4-ty@arm.com>
Date:   Mon, 29 Nov 2021 13:41:05 +0000
From:   Lorenzo Pieralisi <lorenzo.pieralisi@....com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        robh@...nel.org, bhelgaas@...gle.com, kw@...ux.com,
        michal.simek@...inx.com
Cc:     Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] PCI: xilinx-nwl: Simplify code and fix a memory leak

On Sun, 7 Nov 2021 11:04:43 +0100, Christophe JAILLET wrote:
> Allocate space for 'bitmap' in 'struct nwl_msi' at build time instead of
> dynamically allocating the memory at runtime.
> 
> This simplifies code (especially error handling paths) and avoid some
> open-coded arithmetic in allocator arguments
> 
> This also fixes a potential memory leak. The bitmap was never freed. It is
> now part of a managed resource.
> 
> [...]

Applied to pci/xilinx-nwl, thanks!

[1/1] PCI: xilinx-nwl: Simplify code and fix a memory leak
      https://git.kernel.org/lpieralisi/pci/c/e2b86f9777

Thanks,
Lorenzo