linux-kernel - RE: [PATCH AUTOSEL 5.15 27/39] ata: ahci: Add Green Sardine vendor ID as board_ahci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SA0PR12MB4510887B220088ACAED885B3E2669@SA0PR12MB4510.namprd12.prod.outlook.com>
Date:   Mon, 29 Nov 2021 14:46:17 +0000
From:   "Limonciello, Mario" <Mario.Limonciello@....com>
To:     Sasha Levin <sashal@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
CC:     "Shah, Nehal-bakulchandra" <Nehal-bakulchandra.Shah@....com>,
        Damien Le Moal <damien.lemoal@...nsource.wdc.com>,
        "linux-ide@...r.kernel.org" <linux-ide@...r.kernel.org>
Subject: RE: [PATCH AUTOSEL 5.15 27/39] ata: ahci: Add Green Sardine vendor ID
 as board_ahci_mobile



> -----Original Message-----
> From: Sasha Levin <sashal@...nel.org>
> Sent: Thursday, November 25, 2021 20:32
> To: linux-kernel@...r.kernel.org; stable@...r.kernel.org
> Cc: Limonciello, Mario <Mario.Limonciello@....com>; Shah, Nehal-
> bakulchandra <Nehal-bakulchandra.Shah@....com>; Damien Le Moal
> <damien.lemoal@...nsource.wdc.com>; Sasha Levin <sashal@...nel.org>;
> linux-ide@...r.kernel.org
> Subject: [PATCH AUTOSEL 5.15 27/39] ata: ahci: Add Green Sardine vendor ID
> as board_ahci_mobile
> 
> From: Mario Limonciello <mario.limonciello@....com>
> 
> [ Upstream commit 1527f69204fe35f341cb599f1cb01bd02daf4374 ]
> 
> AMD requires that the SATA controller be configured for devsleep in order
> for S0i3 entry to work properly.
> 
> commit b1a9585cc396 ("ata: ahci: Enable DEVSLP by default on x86 with
> SLP_S0") sets up a kernel policy to enable devsleep on Intel mobile
> platforms that are using s0ix.  Add the PCI ID for the SATA controller in
> Green Sardine platforms to extend this policy by default for AMD based
> systems using s0i3 as well.
> 
> Cc: Nehal-bakulchandra Shah <Nehal-bakulchandra.Shah@....com>
> BugLink:
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugz
> illa.kernel.org%2Fshow_bug.cgi%3Fid%3D214091&amp;data=04%7C01%7Cm
> ario.limonciello%40amd.com%7C2f6ff36f5cec496bfa3608d9b0850ebb%7C3dd
> 8961fe4884e608e11a82d994e183d%7C0%7C0%7C637734907817024215%7CUn
> known%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6
> Ik1haWwiLCJXVCI6Mn0%3D%7C3000&amp;sdata=6eKGOqpi4UfLNb4Q4mmb
> qaMxxoB5wP3A9BSIXiBTRAk%3D&amp;reserved=0
> Signed-off-by: Mario Limonciello <mario.limonciello@....com>
> Signed-off-by: Damien Le Moal <damien.lemoal@...nsource.wdc.com>
> Signed-off-by: Sasha Levin <sashal@...nel.org>
> ---
>  drivers/ata/ahci.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> index 186cbf90c8ead..812731e80f8e0 100644
> --- a/drivers/ata/ahci.c
> +++ b/drivers/ata/ahci.c
> @@ -442,6 +442,7 @@ static const struct pci_device_id ahci_pci_tbl[] = {
>  	/* AMD */
>  	{ PCI_VDEVICE(AMD, 0x7800), board_ahci }, /* AMD Hudson-2 */
>  	{ PCI_VDEVICE(AMD, 0x7900), board_ahci }, /* AMD CZ */
> +	{ PCI_VDEVICE(AMD, 0x7901), board_ahci_mobile }, /* AMD Green
> Sardine */
>  	/* AMD is using RAID class only for ahci controllers */
>  	{ PCI_VENDOR_ID_AMD, PCI_ANY_ID, PCI_ANY_ID, PCI_ANY_ID,
>  	  PCI_CLASS_STORAGE_RAID << 8, 0xffffff, board_ahci },
> --
> 2.33.0

Sasha,

No concerns for me to 5.15 or any of the earlier kernels the autosel picked, but would you mind also sending this to 5.14.y too?

Thanks,