linux-kernel - Re: [PATCH v2 0/3] topology/sysfs: only export used sysfs attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YaTdpsVCDQMlscON@hirez.programming.kicks-ass.net>
Date:   Mon, 29 Nov 2021 15:03:18 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Heiko Carstens <hca@...ux.ibm.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        Len Brown <len.brown@...el.com>,
        Thomas Richter <tmricht@...ux.ibm.com>,
        Ian Rogers <irogers@...gle.com>
Subject: Re: [PATCH v2 0/3] topology/sysfs: only export used sysfs attributes

On Mon, Nov 29, 2021 at 02:03:06PM +0100, Heiko Carstens wrote:
> v2:
> As requested by Greg KH: avoid negative logic and use uppercase defines.
> 
> v1:
> Create die and cluster cpu topology sysfs attributes only if an
> architecture makes uses of it, instead of creating them always for all
> architectures with bogus default values.
> Also change the book and drawer cpu topology macros so they match all
> all other topology macros.
> 
> v1: https://lore.kernel.org/lkml/20211128212221.1069726-1-hca@linux.ibm.com/
> 
> Heiko Carstens (3):
>   topology/sysfs: export die attributes only if an architectures has support
>   topology/sysfs: export cluster attributes only if an architectures has support
>   topology/sysfs: rework book and drawer topology ifdefery
> 
>  Documentation/admin-guide/cputopology.rst | 33 +++++++++++------------
>  drivers/base/topology.c                   | 28 ++++++++++++++-----
>  include/linux/topology.h                  | 25 +++++++++++++++++
>  3 files changed, 62 insertions(+), 24 deletions(-)

Seems entirely reasonable to me,

Acked-by: Peter Zijlstra (Intel) <peterz@...radead.org>