linux-kernel - Re: [GIT PULL] Btrfs fixes for 5.16-rc3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 29 Nov 2021 17:13:10 +0100
From:   David Sterba <dsterba@...e.cz>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     David Sterba <dsterba@...e.com>,
        linux-btrfs <linux-btrfs@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] Btrfs fixes for 5.16-rc3

On Fri, Nov 26, 2021 at 12:48:15PM -0800, Linus Torvalds wrote:
> On Fri, Nov 26, 2021 at 7:42 AM David Sterba <dsterba@...e.com> wrote:
> >
> > one more fix to the lzo code, a missing put_page causing memory leaks
> > when some error branches are taken.
> >
> >   git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.16-rc2-tag
> 
> Hmm.
> 
> pr-tracker-bot didn't react to this one, and it wasn't obvious why.
> 
> Until I started looking closer. You claim:
> 
> > for you to fetch changes up to 504d851ab360dc00e2163acef2e200ea69ac800a:
> >
> >   btrfs: fix the memory leak caused in lzo_compress_pages() (2021-11-26 14:32:40 +0100)
> 
> but in fact it's commit daf87e953527, not as the pull request claims
> 504d851ab360..
> 
> And no, it's not the tag either, that was d0a295f521e2.
> 
> The diffstat and the shortlog matched, so I had pulled it without
> noticing. But something went wrong in there in the pull request.

Possible explanation: I had problems pushing to k.org repo from work
machine (ssh timeout, fetching worked) so I pushed it from a different
one. The branch to pull was recreated from the same commit, with id
daf87e953527b03c0b and pushed to k.org but I must have kept the previous
for-5.16-rc2 branch without update when preparing the pull request mail.