linux-kernel - Re: [PATCH] nvme: duplicate NQNs check if devices needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211129163406.GA3582042@dhcp-10-100-145-180.wdc.com>
Date:   Mon, 29 Nov 2021 08:34:06 -0800
From:   Keith Busch <kbusch@...nel.org>
To:     Liguang Zhang <zhangliguang@...ux.alibaba.com>
Cc:     Jens Axboe <axboe@...com>, Christoph Hellwig <hch@....de>,
        Sagi Grimberg <sagi@...mberg.me>,
        linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nvme: duplicate NQNs check if devices needed

On Mon, Nov 29, 2021 at 07:18:54PM +0800, Liguang Zhang wrote:
> @@ -2587,6 +2587,9 @@ static struct nvme_subsystem *__nvme_find_get_subsystem(const char *subsysnqn)
>  
>  	lockdep_assert_held(&nvme_subsystems_lock);
>  
> +	if (strncmp(subsysnqn, "nqn.", 4))
> +		return NULL;

This seems like an arbitrary way to decide not to check for duplicates.
Shouldn't we just add the NVME_QUIRK_IGNORE_DEV_SUBNQN quirk for the
broken controllers?