linux-kernel - Re: [PATCH v3 07/13] clk: imx: Add initial support for i.MXRT clock driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <de705094-1b8c-3950-b7f5-f7150b525ea5@benettiengineering.com>
Date:   Sun, 28 Nov 2021 23:17:50 +0100
From:   Giulio Benetti <giulio.benetti@...ettiengineering.com>
To:     Jesse Taube <mr.bossman075@...il.com>,
        Fabio Estevam <festevam@...il.com>
Cc:     NXP Linux Team <linux-imx@....com>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        Sascha Hauer <kernel@...gutronix.de>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Dong Aisheng <aisheng.dong@....com>,
        Stefan Agner <stefan@...er.ch>,
        Linus Walleij <linus.walleij@...aro.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Arnd Bergmann <arnd@...db.de>, Olof Johansson <olof@...om.net>,
        soc@...nel.org, Russell King - ARM Linux <linux@...linux.org.uk>,
        Abel Vesa <abel.vesa@....com>,
        Adrian Hunter <adrian.hunter@...el.com>,
        Jiri Slaby <jirislaby@...nel.org>,
        Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@...hiba.co.jp>,
        linux-clk <linux-clk@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-mmc <linux-mmc@...r.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        linux-serial@...r.kernel.org
Subject: Re: [PATCH v3 07/13] clk: imx: Add initial support for i.MXRT clock
 driver

Hi Jesse, Fabio,

On 28/11/21 21:52, Jesse Taube wrote:
> 
> 
> On 11/28/21 15:50, Fabio Estevam wrote:
>> On Thu, Nov 25, 2021 at 6:14 PM Jesse Taube <mr.bossman075@...il.com> wrote:
>>>
>>> From: Jesse Taube <mr.bossman075@...il.com>
>>>
>>> This patch adds initial clock driver support for the i.MXRT series.

Also the commit log must be modified according(Summary+body).

Thank you
-- 
Giulio Benetti
Benetti Engineering sas

>>> Signed-off-by: Jesse Taube <Mr.Bossman075@...il.com>
>>> Suggested-by: Giulio Benetti <giulio.benetti@...ettiengineering.com>
>>> ---
>>> V1->V2:
>>> * Kconfig: Add new line
>>> * clk-imxrt.c: Remove unused const
>>> * clk-imxrt.c: Remove set parents
>>> * clk-imxrt.c: Use fsl,imxrt-anatop for anatop base address
>>> V2->V3:
>>> * Remove unused ANATOP_BASE_ADDR
>>> * Move to hw API
>>> * Add GPT's own clock
>>> * Add SEMC clocks to set muxing to CRITICAL
>>> ---
>>>    drivers/clk/imx/Kconfig     |   4 +
>>>    drivers/clk/imx/Makefile    |   1 +
>>>    drivers/clk/imx/clk-imxrt.c | 156 ++++++++++++++++++++++++++++++++++++
>>
>> Wouldn't it be better to name it clk-imxrt1050.c instead?
> we can have multiple imxrt versions in there like the other IMX clk
> drivers, is this okay?
>>