linux-kernel - Re: [PATCH] microblaze/mm/highmem: Remove redundant initialization of variable maxmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHTX3d+Sc47Cj7Rs7HxWSLapvwXsWa-1-VBknsFLXBPmEhyRLw@mail.gmail.com>
Date:   Mon, 29 Nov 2021 15:50:56 +0100
From:   Michal Simek <monstr@...str.eu>
To:     Colin Ian King <colin.i.king@...glemail.com>
Cc:     David Hildenbrand <david@...hat.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        kernel-janitors@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] microblaze/mm/highmem: Remove redundant initialization of
 variable maxmem

Hi Colin,

pá 26. 11. 2021 v 23:53 odesílatel Colin Ian King
<colin.i.king@...glemail.com> napsal:
>
> The variable maxmem is being initialized with a value that is never
> read, it is being updated later on. The assignment is redundant and
> can be removed.
>
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> ---
>  arch/microblaze/mm/init.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/microblaze/mm/init.c b/arch/microblaze/mm/init.c
> index 952f35b335b2..f328d4549fad 100644
> --- a/arch/microblaze/mm/init.c
> +++ b/arch/microblaze/mm/init.c
> @@ -144,7 +144,7 @@ int page_is_ram(unsigned long pfn)
>   */
>  static void mm_cmdline_setup(void)
>  {
> -       unsigned long maxmem = 0;
> +       unsigned long maxmem;
>         char *p = cmd_line;
>
>         /* Look for mem= option on command line */
> --
> 2.33.1
>

The patch is fine but From and SoB email are different. Please fix it.
./scripts/checkpatch.pl --codespell --strict
0001-microblaze-mm-highmem-Remove-redundant-initializatio.patch
WARNING: From:/Signed-off-by: email address mismatch: 'From: Colin Ian
King <colin.i.king@...glemail.com>' != 'Signed-off-by: Colin Ian King
<colin.i.king@...il.com>'

Thanks,
Michal

-- 
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs