linux-kernel - Re: [PATCH net-next v1] devlink: Simplify devlink resources unregister call

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211130071305.28c3121c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 30 Nov 2021 07:13:05 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Leon Romanovsky <leon@...nel.org>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Ido Schimmel <idosch@...dia.com>, Jiri Pirko <jiri@...dia.com>,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        Vivien Didelot <vivien.didelot@...il.com>,
        Vladimir Oltean <olteanv@...il.com>
Subject: Re: [PATCH net-next v1] devlink: Simplify devlink resources
 unregister call

On Tue, 30 Nov 2021 10:00:28 +0200 Leon Romanovsky wrote:
> > Hiding struct devlink_resource is not mentioned in the commit message
> > and entirely unrelated to removal of the unused argument.  
> 
> devlink_resources_unregister() was the API function that is declared in
> the devlink.h that used "struct devlink_resource". Once we removed extra
> parameter from that function, the "struct devlink_resource" left as not
> used at all. So this "hiding" is related and part of this simplification
> patch.
> 
> I will add it to the commit message.

Forward declarations exist. The author did not have to disclose the
definition of the structure. Removing this definition is not related,
you just like doing it.