linux-kernel - Re: [PATCH v1] perf trace: Enable ignore_missing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 30 Nov 2021 12:16:38 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Gang Li <ligang.bdlg@...edance.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] perf trace: Enable ignore_missing_thread for trace

Em Tue, Nov 23, 2021 at 03:40:17PM +0800, Gang Li escreveu:
> perf already support ignore_missing_thread for -u/-p, but not yet
> applied to `perf trace`. This patch enable ignore_missing_thread
> for `perf trace`.
> 
> ref:
> Link: http://lkml.kernel.org/r/1481538943-21874-6-git-send-email-jolsa@kernel.org
> Link: http://lkml.kernel.org/r/1513148513-6974-1-git-send-email-zhangmengting@huawei.com
> Signed-off-by: Gang Li <ligang.bdlg@...edance.com>
> ---
>  tools/perf/builtin-trace.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
> index 0b52e08e558e..94d62a92f1a1 100644
> --- a/tools/perf/builtin-trace.c
> +++ b/tools/perf/builtin-trace.c
> @@ -3950,6 +3950,9 @@ static int trace__run(struct trace *trace, int argc, const char **argv)
>  		evlist__add(evlist, pgfault_min);
>  	}
>  
> +	/* Enable ignoring missing threads when -u/-p option is defined. */
> +	trace->opts.ignore_missing_thread = trace->opts.target.uid != UINT_MAX || trace->opts.target.pid;
> +
>  	if (trace->sched &&
>  	    evlist__add_newtp(evlist, "sched", "sched_stat_runtime", trace__sched_stat_runtime))
>  		goto out_error_sched_stat_runtime;

Thanks, applied.

- Arnaldo