linux-kernel - Re: [PATCH] selftests/ftrace: make kprobe profile testcase description unique

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0fc3e982-456f-628d-17a3-f9c631108f6f@linuxfoundation.org>
Date:   Tue, 30 Nov 2021 09:21:07 -0700
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Steven Rostedt <rostedt@...dmis.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Heiko Carstens <hca@...ux.ibm.com>,
        Shuah Khan <shuah@...nel.org>
Cc:     linux-kernel@...r.kernel.org,
        Alexander Egorenkov <egorenar@...ux.ibm.com>,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] selftests/ftrace: make kprobe profile testcase
 description unique

On 11/30/21 9:01 AM, Steven Rostedt wrote:
> On Tue, 30 Nov 2021 23:11:30 +0900
> Masami Hiramatsu <mhiramat@...nel.org> wrote:
> 
>> On Tue, 30 Nov 2021 13:25:46 +0100
>> Heiko Carstens <hca@...ux.ibm.com> wrote:
>>
>>> Commit 32f6e5da83c7 ("selftests/ftrace: Add kprobe profile testcase")
>>> added a new kprobes testcase, but has a description which does not
>>> describe what the test case is doing and is duplicating the desription

Typo - I can fix it when I apply. checkpatch.pl does it for you btw.

>>> of another test case.
>>> Therefore change the test case description, so it is unique and then
>>> allows easily to tell which test case actually passed or failed.
>>
>> Good catch!
>>
>> This looks good to me.
>>
>> Acked-by: Masami Hiramatsu <mhiramat@...nel.org>
>>
> 
> Shuah,
> 
> Care to take this through your tree?
> 

Yes. I can queue this up.

thanks,
-- Shuah