linux-kernel - RE: [RFC PATCH 5/6] crypto: xilinx: Add Xilinx SHA3 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SJ0PR02MB7279ADF2CBC68F753B43288FDE679@SJ0PR02MB7279.namprd02.prod.outlook.com>
Date:   Tue, 30 Nov 2021 16:38:38 +0000
From:   Harsha Harsha <harshah@...inx.com>
To:     Randy Dunlap <rdunlap@...radead.org>,
        "herbert@...dor.apana.org.au" <herbert@...dor.apana.org.au>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Michal Simek <michals@...inx.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
CC:     Sarat Chand Savitala <saratcha@...inx.com>,
        Harsh Jain <harshj@...inx.com>
Subject: RE: [RFC PATCH 5/6] crypto: xilinx: Add Xilinx SHA3 driver

Hi Randy,

Thanks for reviewing the patch. I will make the following changes:
-  ZynqMP SHA3 hw accelerator -> ZynqMP SHA3 hardware accelerator
-  SHA3 hw engine -> SHA3 hardware engine

Regards,
Harsha

> -----Original Message-----
> From: Randy Dunlap <rdunlap@...radead.org>
> Sent: Tuesday, November 30, 2021 7:44 PM
> To: Harsha Harsha <harshah@...inx.com>; herbert@...dor.apana.org.au; davem@...emloft.net; linux-crypto@...r.kernel.org;
> linux-kernel@...r.kernel.org; Michal Simek <michals@...inx.com>; linux-arm-kernel@...ts.infradead.org; robh+dt@...nel.org;
> devicetree@...r.kernel.org
> Cc: Sarat Chand Savitala <saratcha@...inx.com>; Harsh Jain <harshj@...inx.com>
> Subject: Re: [RFC PATCH 5/6] crypto: xilinx: Add Xilinx SHA3 driver
> 
> Hi--
> 
> On 11/30/21 00:54, Harsha wrote:
> > diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
> > index 51690e7..5df252e 100644
> > --- a/drivers/crypto/Kconfig
> > +++ b/drivers/crypto/Kconfig
> > @@ -796,6 +796,16 @@ config CRYPTO_DEV_ZYNQMP_AES
> >  	  accelerator. Select this if you want to use the ZynqMP module
> >  	  for AES algorithms.
> >
> > +config CRYPTO_DEV_ZYNQMP_SHA3
> > +	bool "Support for Xilinx ZynqMP SHA3 hw accelerator"
> 
> s/hw/hardware/
> 
> > +	depends on ARCH_ZYNQMP || COMPILE_TEST
> > +	select CRYPTO_SHA3
> > +	help
> > +	  Xilinx ZynqMP has SHA3 engine used for secure hash calculation.
> > +	  This driver interfaces with SHA3 hw engine.
> 
> s/hw/hardware/
> 
> > +	  Select this if you want to use the ZynqMP module
> > +	  for SHA3 hash computation.
> 
> thanks.
> --
> ~Randy