linux-kernel - Re: [PATCHv3 0/4] Add generic MMIO instruction deconding to be used in SEV and TDX

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YaZUJIXJC2OVFSth@suse.de>
Date:   Tue, 30 Nov 2021 17:41:08 +0100
From:   Joerg Roedel <jroedel@...e.de>
To:     "Kirill A. Shutemov" <kirill@...temov.name>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Tom Lendacky <thomas.lendacky@....com>,
        Kuppuswamy Sathyanarayanan 
        <sathyanarayanan.kuppuswamy@...ux.intel.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Dave Hansen <dave.hansen@...el.com>,
        Sean Christopherson <seanjc@...gle.com>,
        Peter Zijlstra <peterz@...radead.org>, x86@...nel.org,
        linux-kernel@...r.kernel.org,
        "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
Subject: Re: [PATCHv3 0/4] Add generic MMIO instruction deconding to be used
 in SEV and TDX

On Wed, Nov 03, 2021 at 06:45:51PM +0300, Kirill A. Shutemov wrote:
> Both AMD SEV and Intel TDX has to decode MMIO instruction to be able to
> handle MMIO.
> 
> Extract insn_decode_mmio() from SEV code. TDX will also use this helper.
> 
> v3:
>  - Handle insn_get_opcode() in is_string_insn()
> v2:
>  - insn_get_modrm_reg_ptr() returns unsigned long pointer now (PeterZ);
>  - Handle insn_get_opcode() failure in insn_decode_mmio() (PeterZ);
> 
> Kirill A. Shutemov (4):
>   x86/insn-eval: Handle insn_get_opcode() failure
>   x86/insn-eval: Introduce insn_get_modrm_reg_ptr()
>   x86/insn-eval: Introduce insn_decode_mmio()
>   x86/sev-es: Use insn_decode_mmio() for MMIO implementation
> 
>  arch/x86/include/asm/insn-eval.h |  13 +++
>  arch/x86/kernel/sev.c            | 171 ++++++++-----------------------
>  arch/x86/lib/insn-eval.c         | 109 +++++++++++++++++++-
>  3 files changed, 160 insertions(+), 133 deletions(-)

Testing looks good here:

Tested-by: Joerg Roedel <jroedel@...e.de>

-- 
Jörg Rödel
jroedel@...e.de

SUSE Software Solutions Germany GmbH
Maxfeldstr. 5
90409 Nürnberg
Germany
 
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev